Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Comment" keyboard shortcut in Quick filter doesn't work anymore #777

Closed
Joey79100 opened this issue Oct 23, 2019 · 3 comments

Comments

@Joey79100
Copy link

@Joey79100 Joey79100 commented Oct 23, 2019

Steps to reproduce this issue

  1. Select any table, and select the Data tab.
  2. Open the Quick filter area.
  3. Type something in it.
  4. Press your keyboard shortcut for "Comment line" to comment what you've typed.

Current behavior

Nothing happens: the line isn't commented as expected.

Expected behavior

The current line should be commented.

In the previous version, it used to work but threw an exception everytime. I reported this exception using the integrated error reporting system a few days/weeks ago (can't remember), but now the shortcut is completely disabled in this context. It is working in a normal query tab. I wonder if this is related, but I did not see a commit mentionning this so I'm not sure.

Environment

  • HeidiSQL version: 10.2.0.5722
  • Operating system: Windows 10 1809
ansgarbecker added a commit that referenced this issue Oct 23, 2019
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Oct 23, 2019

I just fixed the exception, as I was trying to reproduce that. My "un/comment" works now as expected here.

Probably you clicked somewhere else where I did not click, to get the action disabled. Please post where you exactly clicked, if the action still does nothing for you in the next build.

@Joey79100

This comment has been minimized.

Copy link
Author

@Joey79100 Joey79100 commented Oct 23, 2019

Okay, I've just tried again, the shortcut is working, and the exception is actually still there. I'm really sorry, this is the second time I post an issue and it was actually my fault. Well, at least this time it won't be useless since you fixed the exception, but still, I'll have to be more careful next time. Thank you.

@Joey79100 Joey79100 closed this Oct 23, 2019
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Oct 23, 2019

No problem, as long as you provide feedback quickly.

I suppose the exception is fixed for you also in the new build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.