Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hightlight is not correctly rendered in dark themes #789

Open
szmcdull opened this issue Nov 1, 2019 · 2 comments
Milestone

Comments

@szmcdull
Copy link

@szmcdull szmcdull commented Nov 1, 2019

Steps to reproduce this issue

  1. In Tools > Preferences, change Style Theme to Cobalt XEMedia;
  2. Close and restart HeidiSQL to apply the theme;
  3. The Session manager comes up;
  4. Notice that the selected and hovered items in the session name list are not correctly highlighted.
  5. The same issue applies to many other places. E.g., the table list (the left pane), all pages in the Host tab, the Database tab, column list in the Table tab;
  6. The same issue applies to other dark themes, although not so noticeable (all highlights are rendered as black bars instead of the color specified by themes).

Current behavior

image

Expected behavior

image

Possible solution

Environment

  • HeidiSQL version: Probably all nightly builds listed in https://www.heidisql.com/download.php (5681-5730). The stable release is fine.
  • Database system and version: MySQL 5.5
  • Operating system: Windows 10 1903
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Nov 1, 2019

Yes, can confirm that. Probably an issue in VirtualTree, which I should update for the next release. Even other similar components like checklist-boxes have a lighter selection background:

grafik

@ansgarbecker ansgarbecker added this to the v10.4 milestone Nov 1, 2019
ansgarbecker added a commit that referenced this issue Nov 1, 2019
…0 2019. Closes #649. Also related to background color of selected VirtualTree nodes, reported in #789
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Nov 1, 2019

With the latest update in 1f17ed8, selected nodes have that lighter background, at least as long as they have focus:

grafik

However, it seems normal that they get black background again when they lose focus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.