Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: trim input in connection manager #797

Closed
EmilObermayr opened this issue Nov 7, 2019 · 3 comments
Closed

feature request: trim input in connection manager #797

EmilObermayr opened this issue Nov 7, 2019 · 3 comments
Milestone

Comments

@EmilObermayr
Copy link

@EmilObermayr EmilObermayr commented Nov 7, 2019

Steps to reproduce this issue

  1. enter new connection
  2. get hostname by copy and paste accidently with a sorounding whitespace " test.com "
  3. try to connect

Current behavior

connection fails as the hostname ist resolved including the whitespace

Expected behavior

should work like on the command shell (when using no quotes)

Possible solution

  1. trim whitespace

  2. show whitespaces as centered dots

Environment

  • HeidiSQL version:
    Revision 5740 (Ihre: 5740)
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Nov 7, 2019

Good idea. But please also look at the other fields - which one may also be trimmed, and which not?

@EmilObermayr

This comment has been minimized.

Copy link
Author

@EmilObermayr EmilObermayr commented Nov 11, 2019

As far as I know, whitespaces are not allowed in hostnames and DNS-names.
I am not so sure about usernames.
Maybe is showing whitespaces as centered dots the better option.
Additionally there could be a yellow warning triangle with tooltip "string contains unusual characters".

Another tricky character in those strings (including the password) is the backslash \ . The backslash is evaluated differently depending on quotes and such.

So for a straight forward UX, display those dots and show the yellow triangle with tooltip in hostname and username and only the triangle in passwords.

BTW: Database-names are already effectively trimmed.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Dec 11, 2019

Text in most of the input fields on the session manager now gets trimmed when you exit the field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.