Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking too fast on folder will open connection instead of collapse/expand #820

Closed
pauljura opened this issue Dec 2, 2019 · 6 comments
Closed
Labels
Milestone

Comments

@pauljura
Copy link

@pauljura pauljura commented Dec 2, 2019

Steps to reproduce this issue

  1. Step 1; Open a new window
  2. Step 2; Have a connection selected
  3. Step 3; Expand / collapse a folder quickly

Current behavior

Highlighted connection is opened, as if I had double clicked on it

Expected behavior

Folder should expand / collapse without opening connection

Possible solution

Check if the click was on folder or connection

Environment

  • HeidiSQL version:
    10.2.0.5766 (64 bit)
  • Operating system:
    Windows 10 64 bit
    image
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Dec 3, 2019

Can't reproduce this issue here. I am clicking like a beast on the folder symbol, on the open/close symbol left besides it, and on the name of the folder. But HeidiSQL still just expands or collapses the folder. I will double-check this at work, on another pc.

@pauljura

This comment has been minimized.

Copy link
Author

@pauljura pauljura commented Dec 3, 2019

Hi, I made a little gif that will hopefully explain:

  1. If you have a connection selected but you click on the folder name, it will de-select the connection and the problem doesn't occur.
  2. Without a connection selected, clicking on the > symbol works as expected.
  3. But if you have a connection selected and double click on the > symbol then the selected connection gets opened.

heidi

@rentalhost

This comment has been minimized.

Copy link
Collaborator

@rentalhost rentalhost commented Dec 3, 2019

Yep, I could reproduce using your last method now.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Dec 4, 2019

Yes, I overread one has to select a connection first, not a folder. I can also reproduce that here now.

@ansgarbecker ansgarbecker added this to the v10.4 milestone Dec 4, 2019
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Feb 5, 2020

Commit b333de2 updates the VirtualTrees to their latest v7.3. But I'm afraid that doesn't fix this issue.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Feb 5, 2020

Found a fix for it, and just pushed it. Double click on the expand/collapse icons should no longer open a session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.