Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreign keys issue #845

Closed
davekc opened this issue Jan 10, 2020 · 4 comments
Closed

Foreign keys issue #845

davekc opened this issue Jan 10, 2020 · 4 comments
Labels
Milestone

Comments

@davekc
Copy link

@davekc davekc commented Jan 10, 2020

First of all, the foreign keys disappeared (not listed anymore) from the relevant tab.
Creating still them works but are not listed either.

  1. Version 10.3 (from 11 Dec 2019 works as expected)
  2. Build 5806 works fine too
  3. Builds 5807-5809 are not

Possible solution

Revert to a previous version

Environment

Windows 10 x64
MariaDB 10.3.21

Thanks!

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Jan 10, 2020

This is due to work in progress - I am working on a larger code enhancement, which replaces the parsing of CREATE TABLE code with less error prone queries. The 3 things columns, keys and foreign keys are affected here, of which the last is not yet implemented. Issue #12 gave me a hit here, as it was nearly impossible to have one procedure parsing the CREATE code of now 4 different RDBMS.

I will leave this open so we can test and verify this is all working again afterwards.

@ansgarbecker ansgarbecker added this to the v10.4 milestone Jan 10, 2020
@davekc

This comment has been minimized.

Copy link
Author

@davekc davekc commented Jan 10, 2020

That was quick!

Sorry, I did not mean to rush you... Glad to hear that you are aware of the situation and that you are actually working on all this. Maybe I should slow down on nightly builds updates a bit then ;)

Thanks again!

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Jan 12, 2020

Foreign keys should be detected again, at least in MySQL.

Todo: There was and still is no foreign key detection for MSSQL, PostgreSQL and SQLite. But this should go in other tickets, e.g. #158 and #641

@davekc

This comment has been minimized.

Copy link
Author

@davekc davekc commented Jan 13, 2020

MariaDB 10.3 works fine again, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.