Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when mouse moved over data grid after losing connection #878

Closed
fifonik opened this issue Feb 5, 2020 · 3 comments
Closed

Crash when mouse moved over data grid after losing connection #878

fifonik opened this issue Feb 5, 2020 · 3 comments
Milestone

Comments

@fifonik
Copy link

@fifonik fifonik commented Feb 5, 2020

Steps to reproduce this issue

  1. Open HeidiSQL, connect to MySQL server and open any DB in tree;

  2. Click at table in the DB and then click at 'Data' tab:
    HeidiSQL Lost Connection Data

  3. Open MySQL CLI and connect to the same server;

  4. In MySQL CLI issue query 'show processlist;' and notice the process id of HeidiSQL connection. In the MySQL CLI issue 'KILL ;' to disconnect HeidiSQL from the server;

  5. Switch to HeidiSQL and in a few seconds you should see in log 'Connection to closed at ...'.

  6. Now start to move mouse and HeidiSQL will crash as soon as you "touch" the data in the grid:
    HeidiSQL Lost Connection Data Crash

Current behavior

Crash

Expected behavior

No crash

Possible solution

Data grid might be grayed out or HeidiSQL might try to re-connect.

Environment

  • HeidiSQL version:
    HeidiSQL x64 10.3.0.5862 (the latest one at the time of writing)
  • Database system and version:
    MySQL 5.7.23 (the same issue with MariaDB 10.1)
  • Operating system:
    Windows 10 1803
@ansgarbecker ansgarbecker added this to the v11.0 milestone Feb 5, 2020
@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Feb 7, 2020

I believe this is an older issue. Didn't you see that in older versions?

@fifonik

This comment has been minimized.

Copy link
Author

@fifonik fifonik commented Feb 7, 2020

Sure, it is not new to the version mentioned.
Heidi crashed avery morning when I woken up my work PC (with Heidi running).
I just recently found a way to reproduce the issue and then upgraded Heidi to the latest version to check if the issue is still exist.

@ansgarbecker

This comment has been minimized.

Copy link
Collaborator

@ansgarbecker ansgarbecker commented Feb 9, 2020

I just pushed a fix for this crash, now disabling the data grid and displaying a label "No data available".

There may be some more side effects on a disconnected session, so just shout if there are more crashes when you wake up your pc.

@pi-iq

This comment has been minimized.

Copy link

@pi-iq pi-iq commented Feb 12, 2020

Thank you! I can confirm that the fix works with the grid and query tabs at least on 10.3.0.5877

The exception dialog still shows up with lost connection if you click on:

  • a table in the table tree
  • the 'Data'-tab

Luckily it is often possible to successfully click on "continue application", if the connection (tunnel, internet etc) was be resumed before clicking on too many places.

"No data available" is great, but being able to copy paste from the earlier data from a disconnected server would be neat too.

@pi-iq

This comment has been minimized.

Copy link

@pi-iq pi-iq commented Feb 13, 2020

The exeption also happens (10.3.0.5877) when the connection is still down and you try to refresh the database/table tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.