New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch the baseurl with set_api
#41
Switch the baseurl with set_api
#41
Conversation
akash5100
commented
Jul 16, 2022
- Closes Add a way to change the BASEURL #24
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 12 +1
Lines 172 196 +24
=========================================
+ Hits 172 196 +24
Continue to review full report at Codecov.
|
hvpy/io.py
Outdated
if "PRIVATE_URL" in os.environ: | ||
return os.environ["PRIVATE_URL"] + self.__class__.__name__[:-15] + "/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This I assume is now not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to move to initialize _base_url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I think we will need another function (get_api_url
) as you said.
see: #41 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change PRIVATE_URL
to something more specific to hvpy. Remember the environment contains variables that are passed to every program that runs on a system, so "PRIVATE_URL" is too vague.
Let's use HELIOVIEWER_API_URL