Skip to content

feat(tabset): accommodate angular lifecycle #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2020
Merged

feat(tabset): accommodate angular lifecycle #770

merged 1 commit into from
Oct 5, 2020

Conversation

@100stacks
Copy link
Member

@100stacks 100stacks commented Oct 1, 2020 •
edited
Loading

Description

Accommodate Angular lifecycle for Issue #758.

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2077

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented Oct 1, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 8d1bdd8

https://deploy-preview-770--helix-ui.netlify.app

@100stacks 100stacks force-pushed the surf-2077-angular-lifecycle-patch branch from 98cc46e to ee47b2e Compare October 1, 2020 21:08
lalithkarikelli
lalithkarikelli approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

badejayayesubabu
badejayayesubabu approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

@100stacks 100stacks force-pushed the surf-2077-angular-lifecycle-patch branch from ee47b2e to 8d1bdd8 Compare October 5, 2020 15:54
@100stacks 100stacks added this to the HelixUI-v1.1.0 milestone Oct 5, 2020
@100stacks 100stacks merged commit ee9c9a7 into master Oct 5, 2020
@100stacks 100stacks deleted the surf-2077-angular-lifecycle-patch branch October 8, 2020 21:42
@100stacks 100stacks added the Hacktoberfest-Accepted Hacktoberfest 2020 Accepted PR label Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

@badejayayesubabu badejayayesubabu badejayayesubabu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Angular Hacktoberfest-Accepted Hacktoberfest 2020 Accepted PR

Projects

None yet

Milestone

HelixUI-v1.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@100stacks @lalithkarikelli @badejayayesubabu