From b1a61e2717f77bb30624a6dd9b8ecbdc6e355121 Mon Sep 17 00:00:00 2001
From: Patrick Heller <patrick.heller@digistore24.team>
Date: Tue, 23 Jan 2024 21:43:24 +0100
Subject: [PATCH 1/3] starts testing

---
 .github/workflows/main.yaml | 13 +++++++++++++
 psalm.xml                   |  2 +-
 2 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 .github/workflows/main.yaml

diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
new file mode 100644
index 0000000..89d3b57
--- /dev/null
+++ b/.github/workflows/main.yaml
@@ -0,0 +1,13 @@
+name: Tests
+
+on:
+  push:
+
+jobs:
+  psalm:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: cachix/install-nix-action@v22
+      # TODO: check why --ignore-platform-req=ext-redis is needed
+      - run: nix-shell --pure --run "composer install --ignore-platform-req=ext-redis && vendor/bin/psalm --output-format=github"
\ No newline at end of file
diff --git a/psalm.xml b/psalm.xml
index 30527ee..04c1308 100644
--- a/psalm.xml
+++ b/psalm.xml
@@ -12,7 +12,7 @@
 >
     <fileExtensions>
         <extension name=".php" />
-        <extension name=".twig" checker="./vendor/psalm/plugin-symfony/src/Twig/TemplateFileAnalyzer.php"/>
+        <extension name=".twig" checker="/vendor/psalm/plugin-symfony/src/Twig/TemplateFileAnalyzer.php"/>
     </fileExtensions>
     
     <projectFiles>

From ed057544d2502f930967f2ca50b54c113fca9cb1 Mon Sep 17 00:00:00 2001
From: Patrick Heller <patrick.heller@digistore24.team>
Date: Tue, 23 Jan 2024 22:11:23 +0100
Subject: [PATCH 2/3] starts with ci testing

---
 .github/workflows/main.yaml | 30 +++++++++++++-
 Justfile                    |  3 +-
 phpunit.xml.dist            |  5 ++-
 psalm-baseline.xml          | 81 +++++++++++++++++++++++++++++++++++++
 psalm.xml                   |  2 +
 5 files changed, 117 insertions(+), 4 deletions(-)
 create mode 100644 psalm-baseline.xml

diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
index 89d3b57..a82ff82 100644
--- a/.github/workflows/main.yaml
+++ b/.github/workflows/main.yaml
@@ -2,12 +2,38 @@ name: Tests
 
 on:
   push:
-
+  merge_group:
 jobs:
+  style:
+    runs-on: ubuntu-latest
+    defaults: 
+        run:
+            shell: nix-shell --pure --run "bash -euxo pipefail {0}"
+    steps:
+      - uses: actions/checkout@v4
+      - uses: cachix/install-nix-action@v22
+      - run: composer install --ignore-platform-req=ext-redis
+      - run: vendor/bin/ecs
+        
   psalm:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: cachix/install-nix-action@v22
       # TODO: check why --ignore-platform-req=ext-redis is needed
-      - run: nix-shell --pure --run "composer install --ignore-platform-req=ext-redis && vendor/bin/psalm --output-format=github"
\ No newline at end of file
+      - shell: nix-shell --pure --run "bash -euxo pipefail {0}"
+        run: |
+          composer install --ignore-platform-req=ext-redis
+          vendor/bin/psalm --output-format=github
+        
+  phpunit:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: cachix/install-nix-action@v22
+      # TODO: cache the build
+      - shell: nix-shell --pure --run "bash -euxo pipefail {0}"
+        run: |
+            # TODO: check why --ignore-platform-req=ext-redis is needed
+            composer install --ignore-platform-req=ext-redis
+            XDEBUG_MODE=coverage vendor/bin/phpunit --order-by=random --stop-on-error --stop-on-failure
diff --git a/Justfile b/Justfile
index da7585d..2cde53e 100644
--- a/Justfile
+++ b/Justfile
@@ -35,4 +35,5 @@ lint:
     vendor/bin/ecs
     
 fix:
-    vendor/bin/ecs --fix
\ No newline at end of file
+    vendor/bin/ecs --fix
+    just --fmt --unstable
\ No newline at end of file
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index 6c4bfed..2f666e4 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -6,7 +6,7 @@
          backupGlobals="false"
          colors="true"
          bootstrap="tests/bootstrap.php"
-         convertDeprecationsToExceptions="false"
+         executionOrder="depends,defects"
 >
     <php>
         <ini name="display_errors" value="1" />
@@ -23,6 +23,8 @@
         </testsuite>
     </testsuites>
 
+    <!--
+      TODO: fix phpunit config
     <coverage processUncoveredFiles="true">
         <include>
             <directory suffix=".php">src</directory>
@@ -32,6 +34,7 @@
     <listeners>
         <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
     </listeners>
+    -->
 
     <extensions>
     </extensions>
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
new file mode 100644
index 0000000..02d6f11
--- /dev/null
+++ b/psalm-baseline.xml
@@ -0,0 +1,81 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<files
+  psalm-version="5.20.0@3f284e96c9d9be6fe6b15c79416e1d1903dcfef4"
+  php-version="
+    php:8.3.2;
+    apcu:5.1.23;
+    bcmath:8.3.2;
+    calendar:8.3.2;
+    Core:8.3.2;
+    ctype:8.3.2;
+    curl:8.3.2;
+    date:8.3.2;
+    dom:20031129;
+    exif:8.3.2;
+    fileinfo:8.3.2;
+    filter:8.3.2;
+    ftp:8.3.2;
+    gd:8.3.2;
+    gettext:8.3.2;
+    gmp:8.3.2;
+    hash:8.3.2;
+    iconv:8.3.2;
+    imap:8.3.2;
+    intl:8.3.2;
+    json:8.3.2;
+    ldap:8.3.2;
+    libxml:8.3.2;
+    mbstring:8.3.2;
+    mysqli:8.3.2;
+    mysqlnd:mysqlnd 8.3.2;
+    openssl:8.3.2;
+    pcntl:8.3.2;
+    pcre:8.3.2;
+    PDO:8.3.2;
+    pdo_mysql:8.3.2;
+    PDO_ODBC:8.3.2;
+    pdo_pgsql:8.3.2;
+    pdo_sqlite:8.3.2;
+    pgsql:8.3.2;
+    Phar:8.3.2;
+    posix:8.3.2;
+    random:8.3.2;
+    readline:8.3.2;
+    redis:6.0.2;
+    Reflection:8.3.2;
+    session:8.3.2;
+    SimpleXML:8.3.2;
+    soap:8.3.2;
+    sockets:8.3.2;
+    sodium:8.3.2;
+    SPL:8.3.2;
+    sqlite3:8.3.2;
+    standard:8.3.2;
+    sysvsem:8.3.2;
+    tokenizer:8.3.2;
+    xml:8.3.2;
+    xmlreader:8.3.2;
+    xmlwriter:8.3.2;
+    Zend OPcache:8.3.2;
+    Zend OPcache:8.3.2;
+    zip:1.22.3;
+    zlib:8.3.2
+  "
+>
+  <file src="src/Stripe/RemoteEventHandler.php">
+    <MixedMethodCall>
+      <code>__invoke</code>
+    </MixedMethodCall>
+  </file>
+  <file src="src/Stripe/UpdateProduct.php">
+    <RiskyTruthyFalsyComparison>
+      <code><![CDATA[$product->default_price]]></code>
+    </RiskyTruthyFalsyComparison>
+  </file>
+  <file src="src/Stripe/UpdateSubscription.php">
+    <RiskyTruthyFalsyComparison>
+      <code><![CDATA[$subscription->cancel_at]]></code>
+      <code><![CDATA[$subscription->canceled_at]]></code>
+    </RiskyTruthyFalsyComparison>
+  </file>
+</files>
diff --git a/psalm.xml b/psalm.xml
index 04c1308..265d9c8 100644
--- a/psalm.xml
+++ b/psalm.xml
@@ -9,6 +9,8 @@
     findUnusedCode="true"
     findUnusedPsalmSuppress="true"
     findUnusedVariablesAndParams="true"
+    errorBaseline="psalm-baseline.xml"
+    includePhpVersionsInErrorBaseline="true"
 >
     <fileExtensions>
         <extension name=".php" />

From 41f055c2908ff4742a14e67697145269b981d8f0 Mon Sep 17 00:00:00 2001
From: Patrick Heller <patrick.heller@digistore24.team>
Date: Tue, 23 Jan 2024 22:47:31 +0100
Subject: [PATCH 3/3] multi step

---
 .github/workflows/main.yaml | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
index a82ff82..db31fe4 100644
--- a/.github/workflows/main.yaml
+++ b/.github/workflows/main.yaml
@@ -14,15 +14,36 @@ jobs:
       - uses: cachix/install-nix-action@v22
       - run: composer install --ignore-platform-req=ext-redis
       - run: vendor/bin/ecs
+      - run: bin/console cache:warmup
+      - run: bin/console lint:twig templates -n --format=github
+      - run: composer validate composer.json --no-check-publish
+      - run: symfony security:check
+#      symfony security:check
+#      vendor/bin/parallel-lint src public migrations config
+#      composer validate composer.json --no-check-publish
+#      XDEBUG_MODE=off bin/composer-require-checker --no-interaction --config-file=$PWD/composer-require-checker.json
+#      vendor/bin/config-transformer --dry-run
+#      bin/console lint:container -n
+#      bin/console cache:warmup
+#      bin/console lint:twig templates -n {{ if output == "github" { "--format=github" } else { "" } }}
+#      bin/console lint:yaml . *.yaml --parse-tags -n {{ if output == "github" { "--format=github" } else { "" } }}
+#      bin/console debug:translation --all --only-missing en
+#      bin/console lint:xliff translations --no-interaction {{ if output == "github" { "--format=github" } else { "" } }}
+#      vendor/bin/rector --dry-run
+#      vendor/bin/php-cs-fixer fix --dry-run --diff
+#      vendor/bin/psalm {{ if output == "github" { "--output-format=github" } else { "" } }}
+#      vendor/bin/phpstan -v --memory-limit=1G {{ if output == "github" { "--error-format=github" } else { "" } }}
+#      cd .. && pnpm spectral lint openapi.yaml {{ if output == "github" { "--format=github-actions" } else { "" } }}
         
   psalm:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: cachix/install-nix-action@v22
-      # TODO: check why --ignore-platform-req=ext-redis is needed
       - shell: nix-shell --pure --run "bash -euxo pipefail {0}"
         run: |
+          # TODO: cache composer dependencies
+          # TODO: check why --ignore-platform-req=ext-redis is needed
           composer install --ignore-platform-req=ext-redis
           vendor/bin/psalm --output-format=github
         
@@ -34,6 +55,7 @@ jobs:
       # TODO: cache the build
       - shell: nix-shell --pure --run "bash -euxo pipefail {0}"
         run: |
+            # TODO: cache composer dependencies
             # TODO: check why --ignore-platform-req=ext-redis is needed
             composer install --ignore-platform-req=ext-redis
             XDEBUG_MODE=coverage vendor/bin/phpunit --order-by=random --stop-on-error --stop-on-failure