Permalink
Commits on Apr 18, 2014
  1. Improve regex match syntax in Validatable

    allolex committed Apr 18, 2014
    Use the === operator instead of !! and =~ with parentheses. It's so much easier to read.
Commits on Feb 1, 2014
  1. Use defaults in Suretax.configuration

    allolex committed Jan 27, 2014
    - Allow arguments passed in to initializers to override defaults.
    - Include configuration example in the Readme
    - Use default client_number
    - Use default validation_key
Commits on Jan 27, 2014
  1. Make method names internally consistent

    allolex committed Jan 27, 2014
    Rename valid_failure_response to post_failed_response_body to be consistent with cancel_failed_response_body.
  2. Move Connection#post and #cancel fully into shared examples

    allolex committed Jan 27, 2014
    - Use do…end or single line let statements with curly braces
  3. Add Connection#cancel

    allolex committed Jan 21, 2014
    - Changed Api::Response to handle optional and fewer fields
    - Tested both failure response and success for #cancel
    - Add cancellation path to Circle CI environment
    - Add cancel path environment variable to Travis
    - Remove redundant connection_v03 spec
Commits on Jan 24, 2014
  1. Upgrade Ruby to 2.1

    allolex committed Jan 21, 2014
  2. Install json gem for rubinius

    allolex committed Jan 24, 2014
  3. Fix Gemfile path

    allolex committed Jan 24, 2014
  4. Fix Travis CI errors for Rubinius

    allolex committed Jan 24, 2014
    Rubinius no longer includes the standard library as part of core, so standard library gems need to be loaded explicitly.
  5. Add Travis CI configuration

    allolex committed Jan 24, 2014
Commits on Jan 17, 2014
Commits on Jan 15, 2014
  1. Add RequestItem validations

    allolex committed Jan 15, 2014
    Added validations for the last remaining fields in RequestItem
  2. Add synopsis to readme

    allolex committed Jan 15, 2014
  3. Add Request validations

    allolex committed Jan 10, 2014
    - Validation method names reflect the specific business entities they are supposed to validate.
    - Use a uniform style with "is_a_valid_xxxxx?".
    - Phone number expectations are in shared examples
    - Validate required and optional fields
Commits on Jan 9, 2014
  1. Move Validatable module into Concerns namespace

    allolex committed Jan 9, 2014
    This makes it clearer that Validatable is to be used as a mixin.
Commits on Jan 7, 2014
  1. Use a Request object when querying the SureTax API

    allolex committed Jan 2, 2014
      - Build an API query using Request
      - Ask the Request instance whether it is valid
Commits on Jan 2, 2014
  1. Merge pull request #9 from allolex/better_responses

    allolex committed Jan 2, 2014
    Fixed a load of problems @davidtrogers pointed out and added the remaining ones as Issues
  2. Change class name from TaxAmount to generic Amount

    allolex committed Jan 2, 2014
    This class works with all money amounts, so its name should not be specific to taxes.
  3. Use Monetize (Money) gem for currency amounts

    allolex committed Jan 2, 2014
    - Parse input using Monetize.parse
    - Register custom USD currency with six decimal places as US6
Commits on Dec 21, 2013
  1. Fix test for truthiness in Api::Response

    allolex committed Dec 21, 2013
    And use Rspec idiomatically
Commits on Dec 18, 2013
  1. Remove redundant leading namespaces

    allolex committed Dec 18, 2013
    Suretax:: etc is not necessary within the Suretax module
  2. Remove VCR dependency

    allolex committed Dec 18, 2013