Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization #15

Merged
merged 10 commits into from Nov 17, 2018
Merged

Localization #15

merged 10 commits into from Nov 17, 2018

Conversation

HelloMatthewMurphy
Copy link
Owner

No description provided.

BrianArch96
BrianArch96 requested changes Nov 15, 2018
View reviewed changes
Copy link
Collaborator

@BrianArch96 BrianArch96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All nitpicks, really good stuff

CS4125Project/src/Database/LocalizationDB.java Outdated Show resolved Hide resolved
CS4125Project/src/Database/LocalizationDB.java Outdated Show resolved Hide resolved
CS4125Project/src/Database/LocalizationDB.java Outdated Show resolved Hide resolved
CS4125Project/src/Database/LocalizationDB.java Show resolved Hide resolved
CS4125Project/src/Language/LocalizationLanguage.java Outdated Show resolved Hide resolved
CS4125Project/src/MenuUI/CheckoutUI.java Outdated Show resolved Hide resolved
CS4125Project/src/MenuUI/PurchaseHistoryUI.java Outdated Show resolved Hide resolved
CS4125Project/src/MenuUI/PurchaseHistoryUI.java Outdated Show resolved Hide resolved
@GameOverJack GameOverJack self-requested a review November 15, 2018 13:03
GameOverJack
GameOverJack approved these changes Nov 15, 2018
View reviewed changes
Copy link
Collaborator

@GameOverJack GameOverJack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

ShaneOMalley
ShaneOMalley requested changes Nov 16, 2018
View reviewed changes
Copy link
Collaborator

@ShaneOMalley ShaneOMalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stop sleeping on the job, my boy

CS4125Project/src/MenuUI/CheckoutUI.java Outdated Show resolved Hide resolved
@HelloMatthewMurphy HelloMatthewMurphy merged commit bb5eb83 into master Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneOMalley ShaneOMalley ShaneOMalley requested changes

@BrianArch96 BrianArch96 BrianArch96 approved these changes

@GameOverJack GameOverJack GameOverJack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HelloMatthewMurphy @ShaneOMalley @BrianArch96 @GameOverJack