Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Set overload #5

Closed
wants to merge 1 commit into from
Closed

Add Set overload #5

wants to merge 1 commit into from

Conversation

Kemsekov
Copy link
Contributor

I had plenty of situations where I needed to set a whole image in one set invoke so I added this method

@Helmare
Copy link
Owner

Helmare commented Aug 22, 2021

Instead of overriding Set, which is typically used with Color objects, create a new method called Write and include the typical stream parameters like buffer, offset, and count. This is more flexible than just a simple Set.

Also, please document methods and add tests for them, as per the CONTRIBUTE.md. Something similar would be the CopyTo tests.

@Kemsekov
Copy link
Contributor Author

Okey. I'll do as you said.

@Kemsekov
Copy link
Contributor Author

I'll do some fixes and create new commit.

@Helmare
Copy link
Owner

Helmare commented Aug 24, 2021

I made an issue that discusses the new features and a new branch for implementing these so I can approve pull requests quickly without it needing to be official, like in the CONTRIBUTE.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants