Fix indentation issue in option 23#58
Merged
HenriWahl merged 1 commit intoHenriWahl:masterfrom May 10, 2022
Merged
Conversation
Otherwise global nameservers are not returned if not defined in client class but client exists.
Owner
|
@anthonygego thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Option 23 does not seem to be sent to the clients if no
nameservervariable is specified in the clients class even if the globalnameservervariable is set.I think it comes from an indentation issue in the code, as the
elifstatement is currently put after thetransaction.clientcheck. Indenting the block indeed seems to solve the issue.Cordially,
Anthony