Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export make_rng_seeds()? #59

Open
mllg opened this issue Jun 18, 2020 · 2 comments
Open

Export make_rng_seeds()? #59

mllg opened this issue Jun 18, 2020 · 2 comments
Labels

Comments

@mllg
Copy link

mllg commented Jun 18, 2020

Would you consider exporting make_rng_seeds() so that we can use it in mlr3?

@mllg mllg changed the title Export make_rng_seeds() Export make_rng_seeds()? Jun 18, 2020
@HenrikBengtsson
Copy link
Owner

HenrikBengtsson commented Jun 18, 2020

Some quick comments/questions:

  1. How soon do you want it?

  2. It's on my todo list to extract several of the internal utility functions an export them in a 'future.chunks' package. This is then meant to support higher-level, map-reduce packages such as future.apply, doFuture, furrr, ... There are some design decisions to be made before future.chunks can be made available.

  3. Until future.chunks is available, you're welcome to use make_rng_seeds() from future.apply in {{mlr3}} via private, stealth imports hacks - I can make a note about this dependency. If you do, I'd like to ask you to be prepared to move to make use future.chunks when it's available.

What do you think?

@mllg
Copy link
Author

mllg commented Jun 19, 2020

It is not urgent, I can use getFromNamespace() until someone from CRAN starts complaining. Happy to switch to future.chunks as soon as it is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants