Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate current progress() - that name is better used for other purposes #113

Closed
HenrikBengtsson opened this issue May 13, 2021 · 1 comment
Milestone

Comments

@HenrikBengtsson
Copy link
Owner

Background

Currently, progress() creates a progression condition and signals it, cf. message() and message conditions.

However, there are other use cases on the roadmap that might benefit from such a function name, e.g. automagic addition of progressr in map-reduce functions:

y <- progress(future_lapply(X, slow_fcn))
y <- future_lapply(X, slow_fcn) |> progress()  ## R (>= 4.1.0)

Note that this is different from with_progress() which comes in as:

with_progress({
  y <- progress(future_lapply(X, slow_fcn))
  z <- progress(X %>% future_map(slow_fcn))
})

Action

Since I doubt the current progress() is used much by end-users and developers, I'll probably go ahead and deprecate the current progress().

@HenrikBengtsson HenrikBengtsson added this to the Next release milestone May 13, 2021
@HenrikBengtsson HenrikBengtsson changed the title Deprecate current progress() - that name is better used for other purposed Deprecate current progress() - that name is better used for other purposes May 14, 2021
@HenrikBengtsson
Copy link
Owner Author

At least none of the 34 revdep packages uses the progress() function. I just ran revdep checks using:

$ R_PROGRESSR_LIFECYCLE_PROGRESS=defunct revdep/run.R 

without any errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant