New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA_DISPELL doesn't work when in @duel on non-vs map #1847

Open
EyesOfAHawk opened this Issue Sep 26, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@EyesOfAHawk
Contributor

EyesOfAHawk commented Sep 26, 2017

  • I have not modified the source prior to reproducing this issue.
  • I am using the latest version of Hercules.
  • I am aware that this report will be closed or deleted if it becomes obvious that I am stating the false.

Description

I think the title explains it well enough. When in a duel (using @duel atcommand), if you are not already on a map_flag_vs map, you will not be able to use Sage skill 'Dispell' on your opponent.

Test Conditions

Neither player had a party or guild. Map was Lighthalzen with default mapflags.

Expected Behavior

Should be able to Dispell your duel opponent if you are both inside a duel.

Steps To Reproduce The Issue

  1. Go to any map without PVP, GVG, BG, PK, etc. (such as Lighthalzen, it was the map I was on).
  2. Initiate a duel, using your Sage with a leveled Dispell skill, using the @duel command.
  3. Try to dispel your opponent. It will fail (break)

Fix (Maybe)

Should be able to fix by altering the 'fail and no skill message' clause.

if (sd && dstsd && !map_flag_vs(sd->bl.m) &&
((sd->status.party_id == 0 || sd->status.party_id != dstsd->status.party_id) &&
(!sd->duel_group || sd->duel_group != dstsd->duel_group)))
	// Outside PvP and Duels it should only affect party members and no skill fail message.
	break;

I tested the above and it works.

Branch(es):

  • master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment