New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylist - needs to update #2356

Open
AnnieRuru opened this Issue Jan 24, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@AnnieRuru
Copy link
Contributor

AnnieRuru commented Jan 24, 2019

Hercules has implement Stylist UI, but when I look into db\stylist_db.conf,
it seems every Hair Style ID, every Hair Color ID needs to be added manually
so my Question No.1 is,
if the server has over 100 hair styles and over 100 hair color, I have to add 200 configurations
or does it actually crash the client ?
http://herc.ws/board/topic/16515-874-incomplete-styling-shop-support/

https://rathena.org/board/topic/118030-help-restriction-stylist-npc/
Suggestion No.2, I think hercules stylist needs an update
currently this script can throw error on player's client if player using summoner class
or maybe not if the Stylist UI can handle lots of ID ?

Question No.3 Hairstyle 0 can crash client ...?
when I test it doesn't crash my client
so I'm not sure Euphy actually start the ID with 1 because his client crash ?

@4144

This comment has been minimized.

Copy link
Contributor

4144 commented Jan 24, 2019

This about stylist client feature.
I think stylist db copy all official features. For some clients it can be too old or too new.
In client side exists same configuration. For add custom styles need change client config too.
Rytech speak about this feature.

Also probably exists npc with custom stylist script, here i not sure how it works.
In rathena topic look like they speaking about custom script.

@AnnieRuru

This comment has been minimized.

Copy link
Contributor Author

AnnieRuru commented Jan 24, 2019

For add custom styles need change client config too

interested ... its inside a lua/lub file where we can edit, or we have to hex it ?

In rathena topic look like they speaking about custom script.

no, its inside Hercules as well
https://github.com/HerculesWS/Hercules/blob/stable/npc/custom/stylist.txt
this script is seriously outdated, some of our members has made changes to it
http://herc.ws/board/files/file/405-stylist-with-doram-limit-hair-style-and-hair-color/
EDIT: because if Hercules stylist UI can support high number of hair styles and color,
that custom script is no longer useful,
but our db/stylist.conf make it hard for us to insert so many lines

btw hairstyle 0 can crash client ? I tested on my 20180620Re doesn't crash
and clothing with ID 0 has different color than ID 1 ... so I am not so sure about it

@4144

This comment has been minimized.

Copy link
Contributor

4144 commented Jan 24, 2019

For builtin stylist i think related this lua file stylingshopinfo.lub.
For show builtin stylist window need use this script command openstylist (supported from 20150128)
But in herc look like it unused, probably you can create script for using it?

@AnnieRuru

This comment has been minimized.

Copy link
Contributor Author

AnnieRuru commented Jan 24, 2019

For builtin stylist i think related this lua file stylingshopinfo.lub.

yeah this is the info I need, time to add custom stuffs inside

But in herc look like it unused, probably you can create script for using it?

that's we are discussing in rathena forum right now, as we have similar script commands for stylist

@AnnieRuru AnnieRuru referenced this issue Jan 24, 2019

Open

Update stylist.txt #2357

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment