New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with MySQL 8 #2363

Closed
sagunkho opened this Issue Feb 4, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@sagunkho
Copy link
Member

sagunkho commented Feb 4, 2019

Describe the bug
Building with Mysql 8 library is not currently possible.

To Reproduce
Steps to reproduce the behavior:

  1. install Mysql8 via 'brew install mysql'
  2. build hercules as you would normally

Expected behavior
Build without emitting errors.

System specs (please complete the following information):

  • OS: macOS 10.14
  • Hercules Version 51483b4
  • Mode: either
  • Packet version: any
  • Client type: any

Plugins used or source modifications
None

Additional context
Configured with Options:

./configure --with-MYSQL_LIBS=/usr/local/opt/mysql/lib/libmysqlclient.dylib

Configure Output

checking for mysql_config... /usr/local/bin/mysql_config
checking for mysql_init... yes
checking mysql.h usability... yes
checking mysql.h presence... yes
checking for mysql.h... yes
checking MySQL library (required)... yes (8.0.13)

Make Output

	CC	sql.c
sql.c:95:3: error: use of undeclared identifier 'my_bool'
                my_bool reconnect = 1;
                ^
sql.c:96:54: error: use of undeclared identifier 'reconnect'
                mysql_options(&self->handle, MYSQL_OPT_RECONNECT, &reconnect);
                                                                   ^
sql.c:527:19: error: use of undeclared identifier 'my_bool'; did you mean '_Bool'?
        bind->is_null = (my_bool*)out_is_null;
                         ^~~~~~~
                         _Bool
sql.c:527:19: error: expected expression
sql.c:832:3: error: use of undeclared identifier 'my_bool'
                my_bool truncated;
                ^
sql.c:843:21: error: use of undeclared identifier 'truncated'
                        column->error = &truncated;
                                         ^
sql.c:846:8: error: use of undeclared identifier 'truncated'
                        if (truncated) {
                            ^
7 errors generated.
make[1]: *** [obj_sql/sql.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [common_sql] Error 2
@4144

This comment has been minimized.

Copy link
Contributor

4144 commented Feb 5, 2019

Can yo check this pr #2365?

@4144 4144 closed this Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment