Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guild_skill_relog_delay causes timer errors when set to 1 #2591

Closed
Kenpachi2k13 opened this issue Dec 1, 2019 · 0 comments
Closed

guild_skill_relog_delay causes timer errors when set to 1 #2591

Kenpachi2k13 opened this issue Dec 1, 2019 · 0 comments

Comments

@Kenpachi2k13
Copy link
Member

@Kenpachi2k13 Kenpachi2k13 commented Dec 1, 2019

Describe the bug
Setting guild_skill_relog_delay to 1 causes timer errors when guild master relogs.
This is because skill_cooldown_save() sets all cooldown timers to INVALID_TIMER (-1) when character logs out, even though guild skills should be ignore if guild_skill_relog_delay is set to 1.

To Reproduce
Steps to reproduce the behavior:

  1. Set guild_skill_relog_delay in conf/map/battle/guild.conf to 1
  2. Run Hercules
  3. Log in with a guild master character
  4. Go to character select
  5. Log in again

Expected behavior
No error messages showing up in map server console.

Screenshots
timer_error

System specs (please complete the following information):

  • OS: Windows 10 Pro Version 1809
  • Hercules Version v2019.11.17+1
  • Mode: renewal
  • Packet version: 20180418
  • Client type: RE

Plugins used or source modifications
None.

Additional context
None.

Kenpachi2k13 added a commit to Kenpachi2k13/Hercules that referenced this issue Dec 1, 2019
…relog_delay is set to 1.

If guild skills are not ignored when guild_skill_relog_delay is set to 1, the map server will throw error messages if the guild master relogs while cooldown.
Also applied Hercules coding style to skill_cooldown_save().
See HerculesWS#2591
@MishimaHaruna MishimaHaruna added this to the Release v2019.12.15 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.