Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPC scripts #2457

Merged
merged 2 commits into from Jun 2, 2019
Merged

Conversation

Emistry
Copy link
Member

@Emistry Emistry commented May 5, 2019

Pull Request Prelude

Changes Proposed

  • update npc name translation.
    Cougar -> Kuuga Gai, Gaebolg -> Geoborg, Family -> Clan, Magic Gear -> Mado Gear
  • updated mado gear renter npc to enable player to obtain mado gear box and cooling devices.

Issues addressed:
rathena/rathena#3854

@Emistry Emistry added component:scripts Affecting the scripts and NPCs mode:renewal For strictly Renewal issues mode:pre-renewal For strictly Pre-Renewal issues labels May 5, 2019
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Emistry Emistry changed the title Update npc ra 3896 Update NPC scripts May 5, 2019
airplane_01,90,63,0 script Event Switch#pc FAKE_NPC,3,3,{
// Nameless Island and Cursed Monestary Access Quest :: aru_monas
//=========================================================================
airplane_01,90,63,0 script Event Switch#pc -1,3,3,{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here should be FAKE_NPC and not -1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, kindly help re-review the commits too :D

- added option to obtain mado gear box and cooling devices.
@MishimaHaruna MishimaHaruna added this to the Release v2019.06.02 milestone Jun 1, 2019
@MishimaHaruna MishimaHaruna merged commit 7710aac into HerculesWS:master Jun 2, 2019
@Emistry Emistry deleted the update_npc_ra_3896 branch June 2, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:scripts Affecting the scripts and NPCs mode:pre-renewal For strictly Pre-Renewal issues mode:renewal For strictly Renewal issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants