Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of CI dependencies from SPM #703

Closed
balavor opened this issue Feb 16, 2021 · 0 comments · Fixed by #707
Closed

Get rid of CI dependencies from SPM #703

balavor opened this issue Feb 16, 2021 · 0 comments · Fixed by #707

Comments

@balavor
Copy link

balavor commented Feb 16, 2021

What did you do?

  • Install Hero using SPM

What did you expect to happen?

  • Install only Hero library.

What happened instead?

  • Installed Hero and all CI dependencies: SwiftFormat, SwiftLint, Komondor and Danger.
    Possible issue: Conflicts during installation since versions may be different from those that are specified in Package.swift file

In my case they're installed gloally, so those packages are duplication and their entire repository is now stored under SourcePackages folder, increasing time that is required to fetch Hero framework.

Possible solution

Get rid of those dependencies from Hero SPM by using Mint to handle dependencies versions.

JoeMatt added a commit that referenced this issue Feb 22, 2021
Signed-off-by: Joe Mattiello <mail@joemattiello.com>
JoeMatt added a commit that referenced this issue Feb 22, 2021
Signed-off-by: Joe Mattiello <mail@joemattiello.com>
JoeMatt added a commit that referenced this issue Feb 22, 2021
Signed-off-by: Joe Mattiello <mail@joemattiello.com>
JoeMatt added a commit that referenced this issue Mar 2, 2021
Signed-off-by: Joe Mattiello <mail@joemattiello.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant