New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Providing completion for very basic handlers #456

Merged
merged 1 commit into from Jun 6, 2018

Conversation

Projects
None yet
2 participants
@kartikthapar
Contributor

kartikthapar commented May 8, 2018

In some cases, I have felt the need to override some of the completion blocks.
This requires me to provide the completion block as part of the helper function itself.

I also wanted to provide another parameter for unwindToViewController but given how its being used in the current framework and possible external usages, its going to break every single flow.

@lkzhao lkzhao merged commit 28e368c into HeroTransitions:master Jun 6, 2018

@lkzhao

This comment has been minimized.

Show comment
Hide comment
@lkzhao

lkzhao Jun 6, 2018

Collaborator

You are definitely correct, these completion blocks should be added. And also into unwindToViewController as well. At the moment unwindToViewController is more of a hack rather that a robust API and we should put some thoughts into how we should change it.

Anyway, thanks a lot for the contribution!

Collaborator

lkzhao commented Jun 6, 2018

You are definitely correct, these completion blocks should be added. And also into unwindToViewController as well. At the moment unwindToViewController is more of a hack rather that a robust API and we should put some thoughts into how we should change it.

Anyway, thanks a lot for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment