New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont store strong references to Navigation and TabBarController delegates #516

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
4 participants
@mkieselmann
Contributor

mkieselmann commented Aug 17, 2018

Holding strong references leads to reference cycles if the delegate is set to self.

Fixes: #515

Markus Kieselmann
Dont store strong references to Navigation and TabBarController deleg…
…ates

Holding strong references leads to reference cycles if the delegate is set to self.
@SD10

SD10 approved these changes Aug 17, 2018

Good catch 👍

@SD10 SD10 requested a review from lkzhao Aug 17, 2018

@SD10 SD10 merged commit 2d5de74 into HeroTransitions:master Aug 29, 2018

@netspencer

This comment has been minimized.

Show comment
Hide comment
@netspencer

netspencer Sep 7, 2018

amazing! this solved so many issues for me

netspencer commented Sep 7, 2018

amazing! this solved so many issues for me

SD10 added a commit that referenced this pull request Sep 16, 2018

Dont store strong references to Navigation and TabBarController deleg…
…ates (#516)

Holding strong references leads to reference cycles if the delegate is set to self.
@linshizai

This comment has been minimized.

Show comment
Hide comment
@linshizai

linshizai Sep 18, 2018

Cool!! I found this issue last month, now it's solved!!!!

linshizai commented Sep 18, 2018

Cool!! I found this issue last month, now it's solved!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment