Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Keep using default navigation animation direction with RTL languages #520
If the user is using an RTL (right to left) language, the navigation controller is expected to use the inverse transition directions by default:
Currently, it is not working, and the navigation controllers behave as it does in LTR languages.
This commit fixes this issue.
Thanks for this PR
I don't really like the idea of changing the behavior of
I think it's better to use the terms
I'm actually not changing the behavior of
I can fix it at client level easily, but anyway I am using my own fork of Hero in my app because it has another change I needed (#513), so it is not blocking me at all.
- Fix iOS demo app failing and style on iOS 13 - Fix lint warnings and build errors in demo app - Add extra metadata to podspec - Deprecated messages to renamed - Add Joe Mattiello into Podspec authors for publishing - Fix pod lib lint failures - Update Podspec imports to match source imports - Use more minimal import - Remove Swift files from framework bundle products - Remove access modifier warnings (#616) - GitIgnore xcode log files - Docs - Run jazzy against new spec - Docs - Update jazzy config - Bump version to 1.5.0 - Set theme jekyll-theme-midnight - Use custom snapshot for views that implements HeroCustomSnapshotView (#541) - Keep using default navigation animation direction with RTL languages (#520) - Hidden subviews not taken in account in optimized snapshot type (#521) - Update Collection 2.0 (#553) Signed-off-by: Joe Mattiello <email@example.com> # gpg: Signature made Mon Oct 28 21:28:30 2019 EDT # gpg: using RSA key 8D361039DCE5C34A90E4E466A4679EBF9DE83365 # gpg: Good signature from "Joseph Mattiello <firstname.lastname@example.org>" [ultimate] # gpg: aka "Joseph Mattiello <email@example.com>" [ultimate] # gpg: aka "Joseph Mattiello <firstname.lastname@example.org>" [ultimate] # gpg: aka "Joseph Mattiello <email@example.com>" [ultimate] # gpg: aka "Joseph Mattiello (Public Git repo commit identity) <firstname.lastname@example.org>" [ultimate] # Conflicts: # Sources/Extensions/UIView+Hero.swift # Sources/Extensions/UIViewController+Hero.swift