Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden subviews not taken in account in optimized snapshot type #521

Merged
merged 3 commits into from Dec 27, 2018

Conversation

@ManueGE
Copy link
Contributor

ManueGE commented Aug 28, 2018

When using .optimized snapshot type in a UIImageView, the optimized snapshot is ignored if the image view contains at least one subview. This PR change that behavior slightly: it just takes the subviews into account if they are not hidden. So, image views with subviews where all subviews are hidden can still use the optimized snapshot type.

@SD10
SD10 approved these changes Aug 30, 2018
Copy link
Member

SD10 left a comment

@ManueGE Thanks 👍 This seems like a reasonable improvement

@ManueGE

This comment has been minimized.

Copy link
Contributor Author

ManueGE commented Dec 18, 2018

Any new with this PR?

@SD10

This comment has been minimized.

Copy link
Member

SD10 commented Dec 18, 2018

@ManueGE Can you add a changelog entry for this change?

It should go:

  1. Under the "Upcoming Release" header
  2. Under the "Changed" section
  3. Please take care to follow the existing changelog entry format

Thanks

@ManueGE ManueGE force-pushed the Jaumo:hidden_subviews_ignored branch from 49c6564 to dd9cd7e Dec 18, 2018
@ManueGE

This comment has been minimized.

Copy link
Contributor Author

ManueGE commented Dec 18, 2018

Added the changes to the changelog.

@SD10

This comment has been minimized.

Copy link
Member

SD10 commented Dec 27, 2018

Thanks @ManueGE took me a heck of a long time to review this 😢

@SD10
SD10 approved these changes Dec 27, 2018
@SD10 SD10 merged commit 27c0fe5 into HeroTransitions:master Dec 27, 2018
JoeMatt added a commit that referenced this pull request Oct 29, 2019
- Fix iOS demo app failing and style on iOS 13
- Fix lint warnings and build errors in demo app
- Add extra metadata to podspec
- Deprecated messages to renamed
- Add Joe Mattiello into Podspec authors for publishing
- Fix pod lib lint failures
- Update Podspec imports to match source imports
- Use more minimal import
- Remove Swift files from framework bundle products
- Remove access modifier warnings (#616)
- GitIgnore xcode log files
- Docs - Run jazzy against new spec
- Docs - Update jazzy config
- Bump version to 1.5.0
- Set theme jekyll-theme-midnight
- Use custom snapshot for views that implements HeroCustomSnapshotView (#541)
- Keep using default navigation animation direction with RTL languages (#520)
- Hidden subviews not taken in account in optimized snapshot type (#521)
- Update Collection 2.0 (#553)

Signed-off-by: Joe Mattiello <git@joemattiello.com>

# gpg: Signature made Mon Oct 28 21:28:30 2019 EDT
# gpg:                using RSA key 8D361039DCE5C34A90E4E466A4679EBF9DE83365
# gpg: Good signature from "Joseph Mattiello <mail@joemattiello.com>" [ultimate]
# gpg:                 aka "Joseph Mattiello <git@joemattiello.com>" [ultimate]
# gpg:                 aka "Joseph Mattiello <joe@provenance-emu.com>" [ultimate]
# gpg:                 aka "Joseph Mattiello <jmattiello@newscorp.com>" [ultimate]
# gpg:                 aka "Joseph Mattiello (Public Git repo commit identity) <git@joemattiello.com>" [ultimate]

# Conflicts:
#	Sources/Extensions/UIView+Hero.swift
#	Sources/Extensions/UIViewController+Hero.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.