Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Release] Hero 1.4.0 with Swift 4.2 support #534
referenced this pull request
Sep 16, 2018
Builds with no issues! Just a few minor notes :)
But it will delay the release on my end. I guess people can use this branch until I can make the backwards compatability changes
Is backward compatibility a problem, though?
Also, you could set
If there's a critical change that you think is needed for Swift 4 and Swift 4.2, you could rev 2 separate pods. Probably not ideal I guess, though. Just my $0.02 from an early adopter of Swift 4.2
I'm not really sure how much of an issue backward compatibility is and how long we would want to support both versions if we did.
I'm personally fine using Hero 1.3.1 and I can't think of any major upcoming Hero releases that would take place before most people have migrated to Swift 4.2. Unless there are strong objections I'll probably just end up pushing this
Yeah, probably not ideal
Sorry for the delay everyone, I had finally burned out
I added backward compatibility for previous Swift versions and will release this now. Feel free to open an issue if I botched anything in the environment