Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Use custom snapshot for views that implements HeroCustomSnapshotView #541
I found very useful the Optimized snapshots for
But at some point, I found myself needing my custom views a customized snapshot. To solve this issue, I created the
If you like the idea but you'd like to use a better wording or a different approach, let me know, I'll be happy to help.
@ManueGE This is interesting for sure.
I think this is pretty low impact and can provide a lot of value. Can you add a changelog entry for this change?
It should go:
- Fix iOS demo app failing and style on iOS 13 - Fix lint warnings and build errors in demo app - Add extra metadata to podspec - Deprecated messages to renamed - Add Joe Mattiello into Podspec authors for publishing - Fix pod lib lint failures - Update Podspec imports to match source imports - Use more minimal import - Remove Swift files from framework bundle products - Remove access modifier warnings (#616) - GitIgnore xcode log files - Docs - Run jazzy against new spec - Docs - Update jazzy config - Bump version to 1.5.0 - Set theme jekyll-theme-midnight - Use custom snapshot for views that implements HeroCustomSnapshotView (#541) - Keep using default navigation animation direction with RTL languages (#520) - Hidden subviews not taken in account in optimized snapshot type (#521) - Update Collection 2.0 (#553) Signed-off-by: Joe Mattiello <firstname.lastname@example.org> # gpg: Signature made Mon Oct 28 21:28:30 2019 EDT # gpg: using RSA key 8D361039DCE5C34A90E4E466A4679EBF9DE83365 # gpg: Good signature from "Joseph Mattiello <email@example.com>" [ultimate] # gpg: aka "Joseph Mattiello <firstname.lastname@example.org>" [ultimate] # gpg: aka "Joseph Mattiello <email@example.com>" [ultimate] # gpg: aka "Joseph Mattiello <firstname.lastname@example.org>" [ultimate] # gpg: aka "Joseph Mattiello (Public Git repo commit identity) <email@example.com>" [ultimate] # Conflicts: # Sources/Extensions/UIView+Hero.swift # Sources/Extensions/UIViewController+Hero.swift