Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom snapshot for views that implements HeroCustomSnapshotView #541

Merged
merged 4 commits into from Dec 27, 2018

Conversation

@ManueGE
Copy link
Contributor

ManueGE commented Sep 25, 2018

I found very useful the Optimized snapshots for UIImageView, UIStackView, Bars, ...

But at some point, I found myself needing my custom views a customized snapshot. To solve this issue, I created the HeroCustomSnapshotView protocol, that a view can implement in order to provide their own optimized snapshot. It has no impact in the rest of the library, but it can make it a little more flexible.

If you like the idea but you'd like to use a better wording or a different approach, let me know, I'll be happy to help.

@ManueGE

This comment has been minimized.

Copy link
Contributor Author

ManueGE commented Dec 18, 2018

@SD10 do you think this PR makes sense? if you have any improvement I'll be happy to change or adapt my PR.

@SD10

This comment has been minimized.

Copy link
Member

SD10 commented Dec 18, 2018

@ManueGE This is interesting for sure.

Since the HeroCustomSnapshotView protocol's snapshotView property is optional, its able to fall through to other cases if a snapshotView is not provided. That's pretty cool 👍

I think this is pretty low impact and can provide a lot of value. Can you add a changelog entry for this change?

It should go:

  1. Under the "Upcoming Release" header
  2. Under the "Added" section
  3. Please take care to follow the existing changelog entry format
@ManueGE ManueGE force-pushed the Jaumo:custom_snapshots branch from 8f0ecdc to be8cc65 Dec 18, 2018
@ManueGE

This comment has been minimized.

Copy link
Contributor Author

ManueGE commented Dec 18, 2018

Added the changes to Changelog.

SD10 added 2 commits Dec 27, 2018
@ManueGE

This comment has been minimized.

Copy link
Contributor Author

ManueGE commented Dec 27, 2018

Hi @SD10

Thanks for taking the time of merging master into it.

Do you need me to add any additional change to this PR?

@SD10

This comment has been minimized.

Copy link
Member

SD10 commented Dec 27, 2018

@ManueGE This is good to go. I just didn't have the time to give it the final review last night 😅 I'll work on creating a new release soon too

@SD10
SD10 approved these changes Dec 27, 2018
@SD10 SD10 merged commit 07ef883 into HeroTransitions:master Dec 27, 2018
@ManueGE

This comment has been minimized.

Copy link
Contributor Author

ManueGE commented Dec 27, 2018

Thank you very much @SD10, didn’t want to put more pressure on you, just asked in case you missed it.

Thanks again. 😊

@SD10

This comment has been minimized.

Copy link
Member

SD10 commented Jan 2, 2019

@ManueGE Happy New Year 🎉 Do you have any interest in helping me maintain Hero? 😄 You can reach out to me on Twitter at _SD10_ if you want to talk more

JoeMatt added a commit that referenced this pull request Oct 29, 2019
- Fix iOS demo app failing and style on iOS 13
- Fix lint warnings and build errors in demo app
- Add extra metadata to podspec
- Deprecated messages to renamed
- Add Joe Mattiello into Podspec authors for publishing
- Fix pod lib lint failures
- Update Podspec imports to match source imports
- Use more minimal import
- Remove Swift files from framework bundle products
- Remove access modifier warnings (#616)
- GitIgnore xcode log files
- Docs - Run jazzy against new spec
- Docs - Update jazzy config
- Bump version to 1.5.0
- Set theme jekyll-theme-midnight
- Use custom snapshot for views that implements HeroCustomSnapshotView (#541)
- Keep using default navigation animation direction with RTL languages (#520)
- Hidden subviews not taken in account in optimized snapshot type (#521)
- Update Collection 2.0 (#553)

Signed-off-by: Joe Mattiello <git@joemattiello.com>

# gpg: Signature made Mon Oct 28 21:28:30 2019 EDT
# gpg:                using RSA key 8D361039DCE5C34A90E4E466A4679EBF9DE83365
# gpg: Good signature from "Joseph Mattiello <mail@joemattiello.com>" [ultimate]
# gpg:                 aka "Joseph Mattiello <git@joemattiello.com>" [ultimate]
# gpg:                 aka "Joseph Mattiello <joe@provenance-emu.com>" [ultimate]
# gpg:                 aka "Joseph Mattiello <jmattiello@newscorp.com>" [ultimate]
# gpg:                 aka "Joseph Mattiello (Public Git repo commit identity) <git@joemattiello.com>" [ultimate]

# Conflicts:
#	Sources/Extensions/UIView+Hero.swift
#	Sources/Extensions/UIViewController+Hero.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.