GamePage image is missing logo when available #2466
Assignees
Labels
good first issue
Good for newcomers.
Comments
|
please assign the issue.. would love to work on it! |
No need to assign. Just let us know that you want to work on that. And also if you are stuck go to our discord for help. 👍 |
4 tasks
arielj
pushed a commit
that referenced
this issue
Nov 25, 2023
* Add logo support in GamePage and GamePicture In GamePage component, add logo variable and pass it to GamePicture component. In GamePicture component, add logo parameter; add logo element (same as the CachedImage logo element in GameCard) There was no need to add CSS, since there was already CSS for logo in GamePicture that positions it at the bottom center. * Rename 'logo' variables to 'art_logo' Purpose of this is to maintain naming consistency with other variables, such as 'art_cover' or other 'art_...' * Clean up unnecessary code * Update logo CSS to look like library's logo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
For games that have a separate asset for the logo, we are not showing the logo in the game page:
Add logs
Steps to reproduce
Expected behavior
The logo should be placed over the image like it's done in the library
Screenshots
No response
Heroic Version
Latest Stable
System Information
Not relevant
Additional information
No response
The text was updated successfully, but these errors were encountered: