Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Auto Sync Saves not working on No-GUI mode #2045

Merged
merged 1 commit into from Nov 23, 2022
Merged

[FIX] Auto Sync Saves not working on No-GUI mode #2045

merged 1 commit into from Nov 23, 2022

Conversation

Zarklord
Copy link
Contributor

this resolves #2043

Adds cloud syncing when launching from the Game Card page, or when launched via the CLI.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)

@flavioislima flavioislima requested review from a team, arielj, flavioislima, CommandMC, Nocccer, imLinguin and redromnon and removed request for a team November 22, 2022 13:44
@flavioislima
Copy link
Member

I think this will work but at the same time I wonder if would be easier to just check the NoGui variable that we have on backend on launch.
So on the launch command, check if the autoSyncSaves option is true, if yes, call the sync saves command.
Then after the launch command ends, sync again if it is true.

What do you think?

@flavioislima flavioislima changed the title try to sync when launching a game regardless of where its launched from [FIX] Auto Sync Saves not working on No-GUI mode Nov 23, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this. ⚔️

@flavioislima flavioislima merged commit cf56f57 into Heroic-Games-Launcher:beta Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants