Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: When selecting item from search bar, it will take you directly to item's game page #2614

Conversation

JordanPlayz158
Copy link
Contributor

@JordanPlayz158 JordanPlayz158 commented Apr 7, 2023

As the title says, when you select an item from the autocomplete list, it will take you to the game page for that item rather than currently searching normally and just showing the single item on the grid.

Note: sorry the previous pull request got closed, I was trying to fix the git history and it deleted the branch and it wasn't giving me an option to reopen it


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary) (Didn't believe it was necessary)
  • Created / Updated documentation (If necessary) (Didn't believe it was necessary)

…st, it will go directly to the game's page and clear the filter for next use.
@JordanPlayz158
Copy link
Contributor Author

JordanPlayz158 commented Apr 7, 2023

Here is what the proposed enhancement looks like in practice

2023-04-07.14-18-02.mp4

Copy link
Collaborator

@redromnon redromnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@flavioislima flavioislima merged commit d73aadd into Heroic-Games-Launcher:main Apr 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants