Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Workflows: Disable publishing when building the AppImage #3253

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

CommandMC
Copy link
Collaborator

Electron-Builder tries to be smart and auto-enables publishing if if's on the main branch of a repo (at least it seems that way, it doesn't do this in the PR workflow; can't find anything about this in the docs), which then promptly fails.
Explicitly turn it off

I can't test this locally, let's hope 3rd time's the charm


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Nov 21, 2023
@CommandMC CommandMC self-assigned this Nov 21, 2023
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should work now

@flavioislima flavioislima merged commit f6d7cf3 into main Nov 22, 2023
13 checks passed
@flavioislima flavioislima deleted the fix/workflows-again branch November 22, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants