Skip to content

Fix logging with proton#4113

Merged
arielj merged 3 commits into
mainfrom
fix/umu-logging
Mar 9, 2025
Merged

Fix logging with proton#4113
arielj merged 3 commits into
mainfrom
fix/umu-logging

Conversation

@Etaash-mathamsetty

Copy link
Copy Markdown
Member

Only tested with UMU enabled so far

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj

arielj commented Nov 16, 2024

Copy link
Copy Markdown
Collaborator

"fix" in what sense? what was broken? can you elaborate?

@CommandMC

CommandMC commented Nov 17, 2024

Copy link
Copy Markdown
Member

Proton's logs don't contain the output of Wine/DXVK/VKD3D-Proton. I was under the impression that this was un-resolveable, but it seems the solution was quite simple after all

IMO this should be a change inside UMU itself. It's going to be enabled in Heroic by default at some point in the future (so logging only working with UMU enabled isn't a problem then), and I expect that Lutris (along with other UMU clients) would require the same / a similar change

@Etaash-mathamsetty

Copy link
Copy Markdown
Member Author

Superseded by Open-Wine-Components/umu-launcher#279

@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Nov 17, 2024
@Heroic-Games-Launcher Heroic-Games-Launcher unlocked this conversation Mar 3, 2025
@Etaash-mathamsetty

Etaash-mathamsetty commented Mar 3, 2025

Copy link
Copy Markdown
Member Author

Superseded by Open-Wine-Components/umu-launcher#279

was reverted because it reduced performance (should have been opt-in not opt-out), so reopening this

@arielj arielj force-pushed the fix/umu-logging branch from 271fe0b to f2203c3 Compare March 9, 2025 22:17
@arielj arielj merged commit 511fe4d into main Mar 9, 2025
@arielj arielj deleted the fix/umu-logging branch March 9, 2025 22:19
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants