Fix logging with proton#4113
Merged
Merged
Conversation
Collaborator
|
"fix" in what sense? what was broken? can you elaborate? |
Member
|
Proton's logs don't contain the output of Wine/DXVK/VKD3D-Proton. I was under the impression that this was un-resolveable, but it seems the solution was quite simple after all IMO this should be a change inside UMU itself. It's going to be enabled in Heroic by default at some point in the future (so logging only working with UMU enabled isn't a problem then), and I expect that Lutris (along with other UMU clients) would require the same / a similar change |
Member
Author
|
Superseded by Open-Wine-Components/umu-launcher#279 |
Member
Author
was reverted because it reduced performance (should have been opt-in not opt-out), so reopening this |
fd7f059 to
420a652
Compare
arielj
approved these changes
Mar 7, 2025
flavioislima
approved these changes
Mar 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only tested with UMU enabled so far
Use the following Checklist if you have changed something on the Backend or Frontend: