fix: use egs's flow for epic login#4379
Merged
flavioislima merged 1 commit intoHeroic-Games-Launcher:mainfrom Mar 9, 2025
Merged
fix: use egs's flow for epic login#4379flavioislima merged 1 commit intoHeroic-Games-Launcher:mainfrom
flavioislima merged 1 commit intoHeroic-Games-Launcher:mainfrom
Conversation
imLinguin
requested review from
a team,
CommandMC,
Nocccer,
arielj and
flavioislima
and removed request for
a team
imLinguin
force-pushed
the
fix/epic-login
branch
from
262d2ec to
47f8a22
Compare
arielj
approved these changes
Mar 4, 2025
Collaborator
arielj
left a comment
arielj
left a comment
There was a problem hiding this comment.
Works as expected and way more simple than before
flavioislima
reviewed
Mar 8, 2025
| const userAgent = | ||
| startUrl === epicLoginUrl | ||
| ? 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) EpicGamesLauncher' | ||
| : 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) Chrome/200.0 HeroicGamesLauncher' |
Member
There was a problem hiding this comment.
Hmm, maybe we don't need those double UA tbh, I only added this one to try to fix some issues with random errors on epic login, server errors.
Member
Author
There was a problem hiding this comment.
I'm thinking it may be worth keeping for some browser side loaded apps. Or in the future let users configure user agent strings for browser apps
flavioislima
approved these changes
Mar 8, 2025
Member
flavioislima
left a comment
flavioislima
left a comment
There was a problem hiding this comment.
Good stuff with this refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of routing through legendary.gl/epiclogin we will call different url directly, this should prevent any issues with corrective actions etc..
I have also modified our useragent to contain mention about Heroic
Use the following Checklist if you have changed something on the Backend or Frontend: