Skip to content

[DX] Allow using br tags in translations to avoid confusion#4380

Merged
arielj merged 1 commit into
mainfrom
use-br-in-translations
Mar 6, 2025
Merged

[DX] Allow using br tags in translations to avoid confusion#4380
arielj merged 1 commit into
mainfrom
use-br-in-translations

Conversation

@arielj
Copy link
Copy Markdown
Collaborator

@arielj arielj commented Mar 3, 2025

This PR fixes #4377

There were many translations that were not respecting the indexed placeholders from i18next, adding content between br tags that don't support content.

This PR changes a few things:

  • I removed all the translations that were wrong
  • I updated the ones that were correct to use <br /> instead of <X></X> to avoid confusion in weblate
  • I fixed the config of i18next-parser to generate <br /> tags in the english file
  • I added a script that we can run to run some checks on the translations, I didn't make this a linter step in the CI actions because I don't know if it's correct the way it's implemented now to make it a block (in some languages maybe it makes sense to skip tags), so for now it's a helper script that we can run before releases for a sanity check

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 3, 2025
@arielj arielj requested review from a team, CommandMC, Etaash-mathamsetty, Nocccer, flavioislima and imLinguin and removed request for a team March 3, 2025 23:48
Copy link
Copy Markdown
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arielj arielj merged commit 27212b1 into main Mar 6, 2025
@arielj arielj deleted the use-br-in-translations branch March 6, 2025 03:12
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Minified React error #137" after upgrade to 2.16.0 (Flatpak version)

2 participants