Skip to content

[FIX] Handle checking 'installed_games' file for Crossover#4381

Merged
flavioislima merged 1 commit into
mainfrom
crossover-installed-games-check
Mar 9, 2025
Merged

[FIX] Handle checking 'installed_games' file for Crossover#4381
flavioislima merged 1 commit into
mainfrom
crossover-installed-games-check

Conversation

@arielj

@arielj arielj commented Mar 4, 2025

Copy link
Copy Markdown
Collaborator

Back in November, an installed_games metadata file was introduced to detect when a new game is installed in an already created prefix. This was not handling Crossover bottles properly, since it was always using the configured winePrefix of the settings that is not used for Crossover.

This PR adds the handling of that, creating the installed_games file inside the bottle's folder (essentially a wine prefix) by using some verbose crossover output.

One thing to note is that this will trigger the installation of redistributables once for each game that's already installed since the installed_games file is not there yet, but the same is happening now in linux.

This fixes #4369


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 4, 2025
@arielj
arielj requested review from a team, CommandMC, Etaash-mathamsetty, Nocccer, flavioislima and imLinguin and removed request for a team March 4, 2025 03:18
@flavioislima flavioislima added this to the 2.16.1 Hotfix milestone Mar 9, 2025
@flavioislima
flavioislima merged commit 07b7a04 into main Mar 9, 2025
@flavioislima
flavioislima deleted the crossover-installed-games-check branch March 9, 2025 19:44
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Heroic checks default wine prefix incorrectly when using Crossover on Mac

2 participants