[UX] Default to WineCrossover and DXVK on for Intel macs#4397
Merged
Conversation
arielj
requested review from
a team,
CommandMC,
Etaash-mathamsetty,
Nocccer,
flavioislima and
imLinguin
and removed request for
a team
flavioislima
reviewed
Mar 8, 2025
|
|
||
| const [repository, setRepository] = useState<WineManagerUISettings>( | ||
| isLinux ? protonge : gamePortingToolkit | ||
| isLinux ? protonge : isIntelMac ? wineCrossover : gamePortingToolkit |
Member
There was a problem hiding this comment.
I think those double ternary are not clean, maybe a method for that would be better.
flavioislima
approved these changes
Mar 8, 2025
Member
flavioislima
left a comment
flavioislima
left a comment
There was a problem hiding this comment.
Looks good, left a small comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Heroic defaults to using the Game Porting Toolkit for any mac machine, even though it doesn't support Intel mac. Also, because of that default, DXVK is turned off by default.
The default experience for Intel mac users is really poor because Heroic was setting an invalid configuration from the beginning, leading to a lot of support threads.
This PR changes that to default to Wine-Crossover and DXVK turned on when the computer is an Intel mac.
Use the following Checklist if you have changed something on the Backend or Frontend: