Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager/EthernetInterface settings #24

Merged
merged 10 commits into from Jun 23, 2017

Conversation

Projects
None yet
2 participants
@vranystepan
Copy link
Contributor

commented Jun 22, 2017

I've added a few simple helpers for the configuration of IPv4 parameters.

methods:
get_ilo_ethernet_interface
set_ilo_ipv4_dhcp set iLO to obtain everything from DHCP (IPv4 stack)
set_ilo_ipv4_static set static IPv4 address, mask and gateway
set_ilo_ipv4_dns_servers set DNS servers
set_ilo_hostname set iLO hostname and domain name

Open topics:

  • unit tests
  • documentation (if needed)
@jsmartt
Copy link
Contributor

left a comment

These look good! :) Just a thought though... I know we're not using named parameters (keyword arguments) as a standard across the library, but I'm wondering if we should start with these sorts of new features. Seems like they would do well with most (if not all) of these methods. Thoughts @vranystepan ?

@vranystepan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2017

@jsmartt Yeah, it'll work with all these methods I guess. I will do a few more commits tomorrow, good idea!

@vranystepan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2017

@jsmartt I could not wait until tomorrow. However I had to edit Rubocop config because by default it was validating with 2.0 parser so it was complaining about these keyword arguments ... strange.

AllCops:
  TargetRubyVersion: 2.1
@jsmartt
Copy link
Contributor

left a comment

👍

@jsmartt

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2017

Are you done working on this @vranystepan ?

@vranystepan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2017

@jsmartt yes I am

@jsmartt

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2017

OK, the last thing would be to bump the version. I think 1.3.0 is the correct version

@jsmartt jsmartt merged commit ac171cd into HewlettPackard:master Jun 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jsmartt

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2017

Just release 1.3.0! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.