Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources continue after failed retrieve! #220

Closed
jsmartt opened this issue Mar 22, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@jsmartt
Copy link
Contributor

commented Mar 22, 2017

Scenario/Intent

Many resource providers don't use retrieve! correctly. They will continue even after the retrieval fails.

Environment Details

  • oneview Cookbook Version: 2.1.0

Steps to Reproduce

There are quite a few resources that fit this bug, but one particular one is enclosure_provider. Try to run the :reconfigure or :refresh actions on a non-existent enclosure.

Expected Result

Fail telling me the resource doesn't exist/wasn't found.

Actual Result

It'll fail later on in the execution, often at a place that's hard to determine the real issue from.

Affected Resource Providers:

This list may not be complete or entirely accurate, but based on a quick grep search (grep -r 'retrieve!' libraries/resource_providers/ | grep -v 'raise'), I got the following files to verify/fix:

@jsmartt jsmartt added the bug/bug-fix label Mar 22, 2017

jsmartt added a commit that referenced this issue Mar 22, 2017

@jsmartt jsmartt referenced this issue Mar 22, 2017

Merged

Raise error after failed retrieve #221

3 of 3 tasks complete

@jsmartt jsmartt closed this in #221 Mar 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.