Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected path to required file #267

Merged
merged 4 commits into from
Sep 12, 2017
Merged

Corrected path to required file #267

merged 4 commits into from
Sep 12, 2017

Conversation

vranystepan
Copy link
Contributor

@vranystepan vranystepan commented Sep 12, 2017

Description

Corrected import in api500/Synergy/StorageSystem

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass ($ rake test).
  • Changes are documented in the CHANGELOG.

@@ -9,7 +9,7 @@
# CONDITIONS OF ANY KIND, either express or implied. See the License for the specific
# language governing permissions and limitations under the License.

require_relative '../../api300/synergy/storage_system'
require_relative '../../api500/c7000/storage_system'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could back just one folder level to reference the file: require_relative '../c7000/storage_system'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right :)

Copy link
Member

@ricardogpsf ricardogpsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me! =)
Usually we create commits of prepare release in another PR, but for me no problem.

Copy link
Contributor

@tmiotto tmiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok, but I guess you've linked the wrong issue

@ricardogpsf
Copy link
Member

I changed the issue to #266 .

@vranystepan
Copy link
Contributor Author

Thank you guys, next time I'm gonna make it right :)

@tmiotto tmiotto merged commit 43c486a into HewlettPackard:master Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants