Please sign in to comment.
ext4: avoid deadlock on sync-mounted FS w/o journal
commit c1bb05a upstream. Processes hang forever on a sync-mounted ext2 file system that is mounted with the ext4 module (default in Fedora 16). I can reproduce this reliably by mounting an ext2 partition with "-o sync" and opening a new file an that partition with vim. vim will hang in "D" state forever. The same happens on ext4 without a journal. I am attaching a small patch here that solves this issue for me. In the sync mounted case without a journal, ext4_handle_dirty_metadata() may call sync_dirty_buffer(), which can't be called with buffer lock held. Also move mb_cache_entry_release inside lock to avoid race fixed previously by 8a2bfdc ext: EA block reference count racing fix Note too that ext2 fixed this same problem in 2006 with b2f4903 [PATCH] fix deadlock in ext2 Signed-off-by: Martin.Wilck@ts.fujitsu.com [firstname.lastname@example.org: move mb_cache_entry_release before unlock, edit commit msg] Signed-off-by: Eric Sandeen <email@example.com> Signed-off-by: "Theodore Ts'o" <firstname.lastname@example.org> Signed-off-by: Ben Hutchings <email@example.com>
- Loading branch information...