Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ensure all string variables are fully quoted #110

Merged
merged 1 commit into from Sep 1, 2013

Conversation

Projects
None yet
3 participants
Contributor

lurch commented Aug 26, 2013

No description provided.

@astellingwerf astellingwerf commented on the diff Aug 26, 2013

rpi-update
@@ -86,11 +87,11 @@ function update_sdk {
function update_firmware {
echo " *** Updating firmware"
- rm -rf ${FW_PATH}/*.elf
- rm -rf ${FW_PATH}/*.bin
- cp -v ${FW_REPOLOCAL}/*.elf "${FW_PATH}/"
- cp -v ${FW_REPOLOCAL}/*.bin "${FW_PATH}/"
- cp -v ${FW_REPOLOCAL}/*.dat "${FW_PATH}/"
+ rm -rf "${FW_PATH}/"*.elf
@astellingwerf

astellingwerf Aug 26, 2013

Why don't you include *.elf inside the quotes?

@lurch

lurch Aug 26, 2013

Contributor

Because otherwise it doesn't work ;-)
Compare the output of ls "/boot/*.elf" and ls "/boot/"*.elf

https://www.gnu.org/software/bash/manual/bashref.html#Pattern-Matching
"The special pattern characters must be quoted if they are to be matched literally."

Collaborator

popcornmix commented Aug 31, 2013

Can you squash these commit together?

Contributor

lurch commented Sep 1, 2013

Done, I think.

Collaborator

popcornmix commented Sep 1, 2013

This can't be merged. Can you try rebasing again?

Contributor

lurch commented Sep 1, 2013

How about now - third time lucky? ;)
Thanks for your patience while I try to get git under control.

@popcornmix popcornmix added a commit that referenced this pull request Sep 1, 2013

@popcornmix popcornmix Merge pull request #110 from lurch/patch-1
Ensure all string variables are fully quoted
2c61ad2

@popcornmix popcornmix merged commit 2c61ad2 into Hexxeh:master Sep 1, 2013

Collaborator

popcornmix commented Sep 1, 2013

Looks okay. Thanks for patches.

@lurch lurch deleted the lurch:patch-1 branch Sep 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment