Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature branch #1

Merged
merged 38 commits into from Nov 9, 2019
Merged

Feature branch #1

merged 38 commits into from Nov 9, 2019

Conversation

HeyItsGwen
Copy link
Owner

Opening a pull request to check for stickler errors

HeyItsGwen and others added 29 commits November 6, 2019 11:11
added empty skeleton of a bootstrap formatted file structure: index, style, reboot, images folder.
forgot it in the template, so added to the project
redid the skeleton having learned more about bootstrap, and started work on the nav
made the nav and footer, styled and completed the nav, and started on the footer before remembering to commit
finished the top part of the footer with social media icons and made it responsive using bootstrap and flex, and started work on the bottom part of the footer by adding the cols/sections.
finished the bottom part of the footer and made it responsive
finished the middle section with top story, culture/travel, and more stories, and filled out the featured stories section.
one word edit to remove non-functional class
added the opinion section and bottom sections, as well as ads and styling
fix validation errors brought up by the w3 validator
added linters to root
fix a few stickler errors
still descending specificity
it's all descending specificity from here on out
can you believe
should be the last of them
whoops i forgot
Copy link

@suretrust suretrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HeyItsGwen,

Great job thus far! 🙌 Just a few suggestions to wrap this up:

  • Please see my comments on your code.

Large screen

  • The total height of the three images and captions by the right is equal to the height of the ones on the left. Kindly fix as appropriate, refer to the images below.

height
height2

  • The navbar should be sticky. (The sticky navbar is smaller) Please refer to the image below:

nav

Medium screen

  • The navbar has some alignment issues and should be sticky. Please see the image below:

nav2

Small screen

  • The navbar has some alignment issues and should be sticky. Please see the image below:

nav3

Kindly submit for another code review once these issues have been fixed. Happy coding! 🎉

index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
HeyItsGwen and others added 9 commits November 8, 2019 20:09
resize correctly based on reference
fixed the nav containers alignments, and made sticky act correctly for each breakpoint
w3 validator
fix the last stickler error
@HeyItsGwen
Copy link
Owner Author

Thanks, Saheed! Fixed, validated, and resubmitting 😃

Copy link

@Redvanisation Redvanisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project approved ✔️

Hello @HeyItsGwen 🌟

Nice work on this project, it seems that you have met the requirements so I am approving your project. 👍

You may merge to master and submit a project completion form. 🚀

Good luck! 🍀

@HeyItsGwen
Copy link
Owner Author

Thank you, Radouane!

@HeyItsGwen HeyItsGwen merged commit 7c1b60f into master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants