New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature branch #1
Conversation
added empty skeleton of a bootstrap formatted file structure: index, style, reboot, images folder.
forgot it in the template, so added to the project
redid the skeleton having learned more about bootstrap, and started work on the nav
made the nav and footer, styled and completed the nav, and started on the footer before remembering to commit
finished the top part of the footer with social media icons and made it responsive using bootstrap and flex, and started work on the bottom part of the footer by adding the cols/sections.
finished the bottom part of the footer and made it responsive
finished the middle section with top story, culture/travel, and more stories, and filled out the featured stories section.
one word edit to remove non-functional class
added the opinion section and bottom sections, as well as ads and styling
fix validation errors brought up by the w3 validator
added linters to root
…ek-Clone into feature-branch
fix a few stickler errors
still descending specificity
…ek-Clone into feature-branch
it's all descending specificity from here on out
can you believe
should be the last of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @HeyItsGwen,
Great job thus far! 🙌 Just a few suggestions to wrap this up:
- Please see my comments on your code.
Large screen
- The total height of the three images and captions by the right is equal to the height of the ones on the left. Kindly fix as appropriate, refer to the images below.
- The navbar should be sticky. (The sticky navbar is smaller) Please refer to the image below:
Medium screen
- The navbar has some alignment issues and should be sticky. Please see the image below:
Small screen
- The navbar has some alignment issues and should be sticky. Please see the image below:
Kindly submit for another code review once these issues have been fixed. Happy coding! 🎉
resize correctly based on reference
fixed the nav containers alignments, and made sticky act correctly for each breakpoint
…ek-Clone into feature-branch
w3 validator
fix the last stickler error
Thanks, Saheed! Fixed, validated, and resubmitting 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project approved ✔️
Hello @HeyItsGwen 🌟
Nice work on this project, it seems that you have met the requirements so I am approving your project. 👍
You may merge to master and submit a project completion form. 🚀
Good luck! 🍀
Thank you, Radouane! |
Opening a pull request to check for stickler errors