Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time to retire the message suggesting role="banner" to header elements, now? #25

Open
brucelawson opened this issue Nov 27, 2019 · 2 comments

Comments

@brucelawson
Copy link

@brucelawson brucelawson commented Nov 27, 2019

.. pretty sure this is obsolete in today's browsers? (Ditto contentinfo etc). Happy to make a PR ..

(and perhaps show a message on any main that is not the only/ first main on a page, because 8.06% of pages erroneously contain more than one main landmark (https://almanac.httparchive.org/en/2019/accessibility#main-landmark)

@coliff

This comment has been minimized.

Copy link

@coliff coliff commented Nov 27, 2019

hey Bruce - regarding the 'main' element... according to the W3C ARIA Landmarks Example site can use multiple 'main' elements if they have unique labels (see HTML Techniques tab). Is that incorrect then?
https://www.w3.org/TR/wai-aria-practices/examples/landmarks/main.html
(I personally wouldn't ever use more than 1 main element on a page but curious to know...)

@brucelawson

This comment has been minimized.

Copy link
Author

@brucelawson brucelawson commented Nov 27, 2019

@coliff Hmmm - never seen that doc. That's about role=main on a div. I'm looking at the html element. Spec currently says "A document must not have more than one main element that does not have the hidden attribute specified" (https://html.spec.whatwg.org/multipage/grouping-content.html#the-main-element). I wonder if I'm clever enough to come up with a CSS selector to find that...

brucelawson added a commit to brucelawson/REVENGE.CSS that referenced this issue Nov 27, 2019
Changed multiple main warning to  "Check: Only one <main> element without hidden attribute allowed" See Heydon#25 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.