Fixed amiitool crash (@azsde), samsung crash (@Kidel) and added Wolf Link editor (@masterchan-777 @possi) #14

Merged
merged 26 commits into from Jun 16, 2017

Conversation

Projects
None yet
@Kidel
Contributor

Kidel commented Mar 11, 2017

Everything seems to be working fine on my phones.
After fixing the errors on the main branch I've also merged with @azsde 's fork to resolve the conflicts.

azsde and others added some commits Mar 8, 2017

[DEV] Fixed crash due to amiitool
Updated amiitool to latest version
[DEV] Added BoTW amiibos to the database
Added the following amiibos from Legend of Zelda Breath of The Wild:

- Link (Archer)
- Link (Rider)
- Guardian
- Zelda
- Bokoblin
fix icon a crash on Galaxy family caused by vector icons (NumberForma…
…tException: Invalid float: "1.1.9") and minor refactor for string constants in UI
Merge branch 'master' of https://github.com/azsde/TagMo
# Resolved Conflicts:
#	.gitignore  >> theirs
#	.idea/gradle.xml >> theirs
#	.idea/misc.xml >> theirs
#	.idea/modules.xml >> theirs
#	build.gradle >> ours
#	gradle/wrapper/gradle-wrapper.properties >> ours
Merge pull request #1 from Kidel/master
Fixed crash on Galaxy phones and tablets
@rathren

This comment has been minimized.

Show comment
Hide comment
@rathren

rathren Mar 12, 2017

I am a noob and I am getting the crash on my galaxy phone. I would get a amiibo but they are all sold out :/ any chance I can get a .apk of this version you made? Because I don't know how to install something on my phone withouthaving a .apk. Thank you so much for your work :)

rathren commented Mar 12, 2017

I am a noob and I am getting the crash on my galaxy phone. I would get a amiibo but they are all sold out :/ any chance I can get a .apk of this version you made? Because I don't know how to install something on my phone withouthaving a .apk. Thank you so much for your work :)

@Kidel

This comment has been minimized.

Show comment
Hide comment
@Kidel

Kidel Mar 12, 2017

Contributor

Sorry, but you'll have to wait for the author of this repository to accept this pull request and release an apk. It's not fair if I do it. Compiling it by yourself is not hard however, you don't need any particular skill, basically just install Android Studio, open the project and build it (if Gradle tells you to apply some fixes, just click on the message and do it). If you're having trouble there are many tutorials online.

Contributor

Kidel commented Mar 12, 2017

Sorry, but you'll have to wait for the author of this repository to accept this pull request and release an apk. It's not fair if I do it. Compiling it by yourself is not hard however, you don't need any particular skill, basically just install Android Studio, open the project and build it (if Gradle tells you to apply some fixes, just click on the message and do it). If you're having trouble there are many tutorials online.

@rathren

This comment has been minimized.

Show comment
Hide comment
@rathren

rathren Mar 12, 2017

ok thank you so much I will try it!

rathren commented Mar 12, 2017

ok thank you so much I will try it!

@rathren

This comment has been minimized.

Show comment
Hide comment
@rathren

rathren Mar 13, 2017

whoo I finaly got it to run. But when I hold the amiibo under the phone to write the tag it immediately says:

Error while writing main data (stage 1)
java.io.IO.Exception: Transceive

I don't have a NFC card so I was using a amiibo I already got as NFC card. I could nowhere find out if this is even possible or not but I guessed it is. Do you think I did something wrong when building or is it not possible to use a amiibo instead of a NFC card?

edit: the needed nfc card even seems to be sold out on amazon :/

edit2: ok seems like to write on a amiibo and not card you need to use restore tag and not scan tag. It looks like it works and says done but nothing happend with one amiibo when I scan it it is still the old one

edit3: well seems like it just does not work on a real amiibo. I found a shop and just bought nfc cards. This should clear everything out. Thanks for what you did again :)

rathren commented Mar 13, 2017

whoo I finaly got it to run. But when I hold the amiibo under the phone to write the tag it immediately says:

Error while writing main data (stage 1)
java.io.IO.Exception: Transceive

I don't have a NFC card so I was using a amiibo I already got as NFC card. I could nowhere find out if this is even possible or not but I guessed it is. Do you think I did something wrong when building or is it not possible to use a amiibo instead of a NFC card?

edit: the needed nfc card even seems to be sold out on amazon :/

edit2: ok seems like to write on a amiibo and not card you need to use restore tag and not scan tag. It looks like it works and says done but nothing happend with one amiibo when I scan it it is still the old one

edit3: well seems like it just does not work on a real amiibo. I found a shop and just bought nfc cards. This should clear everything out. Thanks for what you did again :)

@Kidel

This comment has been minimized.

Show comment
Hide comment
@Kidel

Kidel Mar 13, 2017

Contributor

Amiibo is already written. You need an empty nfc 215

Contributor

Kidel commented Mar 13, 2017

Amiibo is already written. You need an empty nfc 215

@Flecktarnfarbe

This comment has been minimized.

Show comment
Hide comment
@Flecktarnfarbe

Flecktarnfarbe Mar 14, 2017

@Kidel NFC Tags arrived today and I have the same error when writing on a new Tag in Auto Mode

Edit: used the wrong Tag (213). I didnt noticed this is a mixed kit. Works fine with a NTAG215 👍

Flecktarnfarbe commented Mar 14, 2017

@Kidel NFC Tags arrived today and I have the same error when writing on a new Tag in Auto Mode

Edit: used the wrong Tag (213). I didnt noticed this is a mixed kit. Works fine with a NTAG215 👍

@Kidel Kidel changed the title from Fixed crash issue on Galaxy phones and tablets and merged with azsde's branch to Fixed amiitool crash (@azsde), samsung crash (@Kidel) and added Wolf Link editor (@masterchan-777 @possi) Mar 14, 2017

@sabatashi

This comment has been minimized.

Show comment
Hide comment
@sabatashi

sabatashi Mar 26, 2017

Hope this gets committed looks good

Hope this gets committed looks good

@sabatashi

This comment has been minimized.

Show comment
Hide comment
@sabatashi

sabatashi Mar 26, 2017

I was able to compile it and it looks good, was wondering though I could've sworn there was an SSB editor when scanning SSB amiibo's? Did SSB editor get disabled? Was it not working? I was under the impression SSB editor was working but it only crashes on non SSB amiibos.

sabatashi commented Mar 26, 2017

I was able to compile it and it looks good, was wondering though I could've sworn there was an SSB editor when scanning SSB amiibo's? Did SSB editor get disabled? Was it not working? I was under the impression SSB editor was working but it only crashes on non SSB amiibos.

javimadgit and others added some commits Apr 8, 2017

@infirit

This comment has been minimized.

Show comment
Hide comment
@infirit

infirit Apr 14, 2017

For anyone who is tired of waiting or does not want to build from source version 2.3 works fine for me.

after 3 months of waiting for @HiddenRambler should he be considered mia?

edit: Anything before the doomed (2.3.3) release is fine. 2.3.3 is literally doomed.

infirit commented Apr 14, 2017

For anyone who is tired of waiting or does not want to build from source version 2.3 works fine for me.

after 3 months of waiting for @HiddenRambler should he be considered mia?

edit: Anything before the doomed (2.3.3) release is fine. 2.3.3 is literally doomed.

@xxBigRonxx

This comment has been minimized.

Show comment
Hide comment
@xxBigRonxx

xxBigRonxx Apr 14, 2017

I was able to build my own using the latest source. Was not difficult at all. Thanks to Kidel for fixing several known issues.

I was able to build my own using the latest source. Was not difficult at all. Thanks to Kidel for fixing several known issues.

@Nomelas

This comment has been minimized.

Show comment
Hide comment
@Nomelas

Nomelas Apr 23, 2017

Thanks @Kidel

I did notice one issue with this though, SSB editing appears to be gone now. though Wolf Link one works fine.

Nomelas commented Apr 23, 2017

Thanks @Kidel

I did notice one issue with this though, SSB editing appears to be gone now. though Wolf Link one works fine.

@sabatashi

This comment has been minimized.

Show comment
Hide comment
@sabatashi

sabatashi Apr 24, 2017

I believe the SSB Editor was still working when it got removed, but the problem was that it would crash the APP if you try to scan a non SSB amiibo so I think it should be readded but maybe with a disclaimer.

I believe the SSB Editor was still working when it got removed, but the problem was that it would crash the APP if you try to scan a non SSB amiibo so I think it should be readded but maybe with a disclaimer.

@Nomelas

This comment has been minimized.

Show comment
Hide comment
@Nomelas

Nomelas Apr 24, 2017

The wolf link editing option doesn't appear unless you scan/load the wolf link amiibo. I think the same can be done for ssb no?

Nomelas commented Apr 24, 2017

The wolf link editing option doesn't appear unless you scan/load the wolf link amiibo. I think the same can be done for ssb no?

@elementcorp

This comment has been minimized.

Show comment
Hide comment
@elementcorp

elementcorp May 8, 2017

I want to thank you all! I made it work smoothly on and old Samsung Note 3 running lollipop 5.0, my wife had on a drawer. It took me a couple of hours (with all your guidance off course and after a few bumps in the way) to learn how to do it. Even for someone like me who has never touch any mobile development tool. My special thanks to @Kidel @HiddenRambler and @rathren for keeping this thread discussion.

I want to thank you all! I made it work smoothly on and old Samsung Note 3 running lollipop 5.0, my wife had on a drawer. It took me a couple of hours (with all your guidance off course and after a few bumps in the way) to learn how to do it. Even for someone like me who has never touch any mobile development tool. My special thanks to @Kidel @HiddenRambler and @rathren for keeping this thread discussion.

@Bombastisch

This comment has been minimized.

Show comment
Hide comment
@Bombastisch

Bombastisch May 16, 2017

Member

God thanks!

The SSB feature wasn't actually removed. He just made the button invisible, because of the known issues mentioned by sabatashi before.

I believe the SSB Editor was still working when it got removed, but the problem was that it would crash the APP if you try to scan a non SSB amiibo so I think it should be readded but maybe with a disclaimer.

You can make the buttons easily visible in Android Studio, but the problems still occur!
I'm not good at programming, but a simple text that says: "No SSB data found" instead of the app crashing would fix the problem I guess.

Member

Bombastisch commented May 16, 2017

God thanks!

The SSB feature wasn't actually removed. He just made the button invisible, because of the known issues mentioned by sabatashi before.

I believe the SSB Editor was still working when it got removed, but the problem was that it would crash the APP if you try to scan a non SSB amiibo so I think it should be readded but maybe with a disclaimer.

You can make the buttons easily visible in Android Studio, but the problems still occur!
I'm not good at programming, but a simple text that says: "No SSB data found" instead of the app crashing would fix the problem I guess.

@Bombastisch

This comment has been minimized.

Show comment
Hide comment
@Bombastisch

Bombastisch Jun 15, 2017

Member

When will HidddenRambler ever merge this pull request? It can't just be that such a awesome project dies out, because of that...

Member

Bombastisch commented Jun 15, 2017

When will HidddenRambler ever merge this pull request? It can't just be that such a awesome project dies out, because of that...

@HiddenRambler HiddenRambler merged commit 89d27a4 into HiddenRamblings:master Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment