New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexicon Bug in iOS -- Urgent #175

Closed
Brahmanathaswami opened this Issue Sep 10, 2018 · 6 comments

Comments

2 participants
@Brahmanathaswami
Collaborator

Brahmanathaswami commented Sep 10, 2018

You need to pull Nightly. to make sure you are could up.

These lexicon was failing both in iOS and Android. It determined that you debug code was interfering. I had leave the debug JS handler in the browser body, but in the card Script is comment is out and out few of the other "put" statements. And now it works on Andriod, but for some reason/webkit Safari will not response have you dismiss they key board. It you type "aah" and click "Done" on the key board, the app locks up!

An android there is no "Done" button... you have to click a few letters and click off the keyboard, this getTheDefinition works as expected, not on iOS.

Consider this urgent!

@soapdog

This comment has been minimized.

Show comment
Hide comment
@soapdog

soapdog Sep 11, 2018

Collaborator

@Brahmanathaswami I will get to this once I am in London.

Collaborator

soapdog commented Sep 11, 2018

@Brahmanathaswami I will get to this once I am in London.

@soapdog

This comment has been minimized.

Show comment
Hide comment
@soapdog

soapdog Sep 18, 2018

Collaborator

@Brahmanathaswami working on it now.

In the future, when doing bug reports, we need to be more direct and specific about what is failing and how to reproduce. You're mention the bug is with keyboard, but it is where? In search? It is also specially good if the bug report has a screenshots.

Collaborator

soapdog commented Sep 18, 2018

@Brahmanathaswami working on it now.

In the future, when doing bug reports, we need to be more direct and specific about what is failing and how to reproduce. You're mention the bug is with keyboard, but it is where? In search? It is also specially good if the bug report has a screenshots.

@soapdog soapdog added the in progress label Sep 18, 2018

@Brahmanathaswami

This comment has been minimized.

Show comment
Hide comment
@Brahmanathaswami

Brahmanathaswami Sep 18, 2018

Collaborator

on iOS

  • you click inside field to enter a few characters
  • Keyboard pop ups
  • enter a few characters
  • click on "Done"

The keyboard remains on screen and you are stuck there.

on Android

  • you click inside field to enter a few characters
  • Keyboard pop ups
  • enter a few characters
  • There is no "done" button,
  • but you click on the app (not the keyboard) and the keyboard goes away
Collaborator

Brahmanathaswami commented Sep 18, 2018

on iOS

  • you click inside field to enter a few characters
  • Keyboard pop ups
  • enter a few characters
  • click on "Done"

The keyboard remains on screen and you are stuck there.

on Android

  • you click inside field to enter a few characters
  • Keyboard pop ups
  • enter a few characters
  • There is no "done" button,
  • but you click on the app (not the keyboard) and the keyboard goes away
@soapdog

This comment has been minimized.

Show comment
Hide comment
@soapdog

soapdog Sep 18, 2018

Collaborator

@Brahmanathaswami working on it now.

Thanks for the detailed recipe. It is late here, I've built most of the code but haven't tried it on a phone yet. I will test it on a real device tomorrow and finish fixing this.

Collaborator

soapdog commented Sep 18, 2018

@Brahmanathaswami working on it now.

Thanks for the detailed recipe. It is late here, I've built most of the code but haven't tried it on a phone yet. I will test it on a real device tomorrow and finish fixing this.

soapdog added a commit that referenced this issue Sep 19, 2018

@soapdog

This comment has been minimized.

Show comment
Hide comment
@soapdog

soapdog Sep 19, 2018

Collaborator

@Brahmanathaswami I've fixed the web app to handle Enter key which is what mobile keyboards send when you press done or go. On both Android and iOS there is always a button near the lower right corner to send Enter. I am trapping that event and unfocusing the search box which causes the keyboard to close.

Collaborator

soapdog commented Sep 19, 2018

@Brahmanathaswami I've fixed the web app to handle Enter key which is what mobile keyboards send when you press done or go. On both Android and iOS there is always a button near the lower right corner to send Enter. I am trapping that event and unfocusing the search box which causes the keyboard to close.

soapdog added a commit that referenced this issue Sep 19, 2018

@soapdog

This comment has been minimized.

Show comment
Hide comment
@soapdog

soapdog Sep 19, 2018

Collaborator

The following work was done to solve this issue:

  • ✔️ upgraded from Elm 0.18 to Elm 0.19 (huge space saving, the new lexicon bundle.js is half the size of previous one.)
  • ✔️ added new onEnter event to the search box, now pressing the mobile keyboard done or go key will cause the keyboard to disappear.
  • ✔️ reverted bad changes in the lexicon stack that were breaking the app.
  • ✔️ switched from remote copies of Noto Font and Font Awesome to local ones.

PS: I tested this fix on Android and it works.

Collaborator

soapdog commented Sep 19, 2018

The following work was done to solve this issue:

  • ✔️ upgraded from Elm 0.18 to Elm 0.19 (huge space saving, the new lexicon bundle.js is half the size of previous one.)
  • ✔️ added new onEnter event to the search box, now pressing the mobile keyboard done or go key will cause the keyboard to disappear.
  • ✔️ reverted bad changes in the lexicon stack that were breaking the app.
  • ✔️ switched from remote copies of Noto Font and Font Awesome to local ones.

PS: I tested this fix on Android and it works.

@soapdog soapdog closed this Sep 19, 2018

soapdog added a commit that referenced this issue Sep 19, 2018

Merge pull request #176 from Himalayan-Academy/update-elm
Fix for #175 - Fix keyboard, Update elm, Switch to local assets

@Brahmanathaswami Brahmanathaswami added this to Updates - Bugs in Version 1.2 Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment