New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #175 - Fix keyboard, Update elm, Switch to local assets #176

Merged
merged 4 commits into from Sep 19, 2018

Conversation

Projects
None yet
1 participant
@soapdog
Collaborator

soapdog commented Sep 19, 2018

The following work was done to solve issue #175:

  • ✔️ upgraded from Elm 0.18 to Elm 0.19 (huge space saving, the new lexicon bundle.js is half the size of previous one.)
  • ✔️ added new onEnter event to the search box, now pressing the mobile keyboard done or go key will cause the keyboard to disappear.
  • ✔️ reverted bad changes in the lexicon stack that were breaking the app.
  • ✔️ switched from remote copies of Noto Font and Font Awesome to local ones.

PS: I tested this fix on Android and it works.

@soapdog soapdog merged commit f7ac4d2 into nightly Sep 19, 2018

@soapdog

This comment has been minimized.

Show comment
Hide comment
@soapdog

soapdog Sep 19, 2018

Collaborator

@Brahmanathaswami merging this to fix keyboard issue.

Collaborator

soapdog commented Sep 19, 2018

@Brahmanathaswami merging this to fix keyboard issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment