New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement for Array2DRowRealMatrix.getSubMatrix() #12

Closed
ebourg opened this Issue Oct 12, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@ebourg
Copy link
Contributor

ebourg commented Oct 12, 2016

Hi the Hipparchus Team :)

A performance improvement to Array2DRowRealMatrix.getSubMatrix() has been applied recently to Commons Math, you may be interested in applying it as well:

https://issues.apache.org/jira/browse/MATH-1389
apache/commons-math@72df12f

With this modification the performance is significantly better when the method hasn't been compiled by the JIT yet (or with non Hotspot JVMs). Once the JIT kicked in its roughly equivalent to the current implementation.

@psteitz

This comment has been minimized.

Copy link
Contributor

psteitz commented Oct 12, 2016

On 10/12/16 7:05 AM, Emmanuel Bourg wrote:

Hi the Hipparchus Team :)

A performance improvement to |Array2DRowRealMatrix.getSubMatrix()|
has been applied recently to Commons Math, you may be interested
in applying it as well:

https://issues.apache.org/jira/browse/MATH-1389
apache/commons-math@72df12f
apache/commons-math@72df12f

With this modification the performance is significantly better
when the method hasn't been compiled by the JIT yet (or with non
Hotspot JVMs). Once the JIT kicked in its roughly equivalent to
the current implementation.

Thanks, Emmanuel!

Phil


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABaU6q2HGDsvZwQFUh5-rlnDRPvmq6sDks5qzM0TgaJpZM4KUrcT.

@maisonobe maisonobe closed this in ca5ae41 Oct 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment