Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLS/GLSLinearRegression sufficient data check is overly aggressive when model has no intercept #13

psteitz opened this issue Nov 12, 2016 · 0 comments


Copy link

@psteitz psteitz commented Nov 12, 2016

The validateSampleData method in AbstractLinearRegression requires that the number of rows in the design matrix is at least one greater than the number of regressors. If the model does not include an intercept term, this check is too stringent: nobs == number of regressors should be allowed in this case.

This issue was surfaced by the StackOverflow question OLS Multiple Linear Regression with commons-math

@psteitz psteitz closed this in 4ab9399 Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant