New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In LogNormalDistribution.java, it appears shape & scale are reversed/mis-labelled. #4

Closed
oleersoy opened this Issue Jun 18, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@oleersoy
Copy link
Contributor

oleersoy commented Jun 18, 2016

Assuming this affects hipparchus as well:
https://issues.apache.org/jira/browse/MATH-1373

@netomi

This comment has been minimized.

Copy link
Contributor

netomi commented Jun 19, 2016

A quick look shows that the calculations are correct, but the parameters are ill-defined:

  • m is the scale parameter: this is the mean of the normally distributed natural logarithm of this distribution
  • s is the shape parameter: this is the standard deviation of the normally distributed natural logarithm of this distribution.

while it should be:

  • m -> location parameter
  • s -> scale parameter

@netomi netomi added bug core labels Jun 28, 2016

@maisonobe maisonobe closed this in dc94ba8 Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment