Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stocks back #10496

Open
JF260 opened this issue Jan 27, 2019 · 16 comments

Comments

@JF260
Copy link

commented Jan 27, 2019

[Title]: # Readd stocks

[Implementation]: # Shouldn't be too difficult, just remove bounties and port the old stocks.

[Why]: # For one, bounties in general suck. Either they demand an insane amount of effort for almost no reward, or they are literally impossible without a round specific antag. Two, stocks are really fun. They're easy to get into and understand, but hard to master, rewarding, and allows cargonians to actually watch over cargonia. Third and finally, I believe bounties originated not from a creative vision, but from a frustration with cargo being able to purchase enough shit to militarize and compete with sec. Therefore, they took the /tg/ route, and nerfed the shit out of everything.

[Resources]: # It would be nice to have some new sprites for it I guess, but totally up to the person who adds it.

Be sure to ask some maintainer to label this issue as a feature. Either ping them on our discord or PM them on our forum. Thank you for sharing your ideas!

@HippieStation/maintainers

@project-bot project-bot bot added this to Issues/Features in Feature board Jan 27, 2019

@k-k-karma

This comment has been minimized.

Copy link

commented Jan 27, 2019

AM NOT ADDING FUCKING STOCKS BACK THEY'RE STUPID BROKEN

@Manly-Dwarf

This comment has been minimized.

Copy link

commented Jan 27, 2019

Shilled his suggestion in OOC.
But maybe. Cargo doesn't have much to do.

@Zyzarda

This comment has been minimized.

Copy link

commented Jan 27, 2019

this but balanced regularly

@waterwater1212

This comment has been minimized.

Copy link

commented Jan 27, 2019

"remove bounties"
"why"
"they suck i don't like them"

@coolguymcman

This comment has been minimized.

Copy link

commented Jan 27, 2019

keep them both, why not. no real conflicting issues between them. not like cargo is gonna be op or anything like science, definitely absolutely not.

@QuarianCommando

This comment has been minimized.

Copy link

commented Jan 27, 2019

Cargo is currently weaker as a department than hydroponics. This is an outrage and must be rectified.

@Lxtoofonea

This comment has been minimized.

Copy link

commented Jan 31, 2019

+1, i loved stocks

@Lxtoofonea

This comment has been minimized.

Copy link

commented Jan 31, 2019

i would like to see a job that does just stocks tho, maybe giving lawyer something to do

@t-f-w

This comment has been minimized.

Copy link

commented Jan 31, 2019

sure +1

@DaydreamPuppeh

This comment has been minimized.

Copy link

commented Jan 31, 2019

+1

@yoyobatty

This comment has been minimized.

Copy link

commented Jan 31, 2019

Sure +1

@yoyobatty yoyobatty added the Feature label Jan 31, 2019

@project-bot project-bot bot moved this from Issues/Features to Features in Feature board Jan 31, 2019

@project-bot project-bot bot moved this from Features to Approved ideas to do in Feature board Jan 31, 2019

@Maroonenahmoron

This comment has been minimized.

Copy link

commented Feb 5, 2019

Yeah man. +1

@mikolaj007

This comment has been minimized.

Copy link

commented Feb 13, 2019

tgstation@cd9ac76
heres the removal commit

@mikolaj007

This comment has been minimized.

Copy link

commented Feb 16, 2019

tfw nobody who actually knows how git works copy-pasted this yet.

@Jujumatic

This comment has been minimized.

Copy link

commented Feb 16, 2019

at least explain how stocks are stupid and broken, suggest a way to fix it and then it's not just a matter of copy-paste ;)

This was referenced Feb 17, 2019

@Carbonhell

This comment has been minimized.

Copy link

commented Mar 6, 2019

Description of the bounty: (Currently 5$)

Add stocks back, by following our coding guidelines (in particular, modularization). Also find out and fix this issue, which was posted in the /tg/ stocks removal PR:
"There seems to be a major issue with stock growth, particularly one bug in particular that grows stock prices to astronomical levels."
Comment the code properly so it is not hard to maintain and edit (unlike how it was before).

Criteria list

  1. Add stocks back (Either by using the last /tg/ implementation, or rewriting them from scratch, doesn't matter)
  2. Ensure they work properly and the prices don't grow exponentially to astronomical levels.
  3. Ensure the whole system is balanced properly and allows for cargo to build a decent amount of cash, without being able to buy literally anything just by using stocks alone.
  4. Document the code as much as possible, in particular variables, so it is easy to maintain and edit.
  5. Write a small guide on how to use the system, from a player's perspective. (If possible, on our wiki: https://wiki.hippiestation.com/index.php )

Link to bountysource: https://www.bountysource.com/issues/69240685-add-stocks-back

The bounty will be paid out when the PR closing the issue is merged. Once a PR is made for a bounty, it will be testmerged for a week when maintainers approve it, so that bounty backers and players can test it to see if it actually resolves the issue in the proper way (If the implementation for the requested feature is correct, or if a bug has been actually fixed, and such).

@k-k-karma k-k-karma added the Bounty label Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.